Closed
Bug 1029215
Opened 11 years ago
Closed 11 years ago
remove 'using namespace mozilla' from js/src
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: luke, Assigned: luke)
Details
Attachments
(1 file)
|
17.95 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
'using namespace mozilla' causes ambiguity errors for common names like 'Vector', requiring explicit qualification with js:: to fix. (If you've ever gotten one of these mystery ambiguities in a .cpp file even though that .cpp doesn't contain 'using namespace mozilla', it's because of unified builds.)
We should probably add this as a rule to the style guide.
Attachment #8444786 -
Flags: review?(jwalden+bmo)
|
||
Updated•11 years ago
|
Attachment #8444786 -
Flags: review?(jwalden+bmo) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/df60afd3e3a7
https://hg.mozilla.org/mozilla-central/rev/d2983539a941
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•