1029232 - Use an Eclipse plugin to build Fennec

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Nick Alexander :nalexander [he/him]]

So, I caved: I've adapted https://github.com/thebnich/fennec-adt to work with the existing code for building Fennec.

It's much, much better, for two reasons:
* we get finer grained control over re-building when inputs change;
* we get more powerful output logging and error marking.

The in-tree code to support this is pretty minimal; this ticket tracks adding that code.  We'll deal with testing the Eclipse plugin somewhere else.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Part 1: Reference generated Java sources correctly. r=trivial

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Part 2: Include rather than reference Fennec Eclipse resources. r=trivial

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Part 3: Call Eclipse builder plugin before Android build steps. r=bnicholson

Flagging bnicholson and/or rnewman for review, although this isn't
quite ready.  I'll push my plugin repo, give you steps to test, and
post a screencast.

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8444815 [details] [diff] [review]
Part 3: Call Eclipse builder plugin before Android build steps. r=bnicholson

Review of attachment 8444815 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a bit mixed about going back to a plugin, but I guess we might as well give it a try since there's a pretty minimal impact on the actual codebase.

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 8444815 [details] [diff] [review]
Part 3: Call Eclipse builder plugin before Android build steps. r=bnicholson

Review of attachment 8444815 [details] [diff] [review]:
-----------------------------------------------------------------

Rubberstamp to get this out of my queue, but I'll be happy to test if you can point me to the plugin!

Comment 6

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/8b9006887332
https://hg.mozilla.org/integration/fx-team/rev/0a0f495093d9
https://hg.mozilla.org/integration/fx-team/rev/0edc7c486fec

Comment 7

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/c1e1dcb83aa3

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8b9006887332
https://hg.mozilla.org/mozilla-central/rev/0a0f495093d9
https://hg.mozilla.org/mozilla-central/rev/0edc7c486fec
https://hg.mozilla.org/mozilla-central/rev/c1e1dcb83aa3