Closed Bug 1029232 Opened 6 years ago Closed 6 years ago

Use an Eclipse plugin to build Fennec

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla33

People

(Reporter: nalexander, Assigned: nalexander)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

So, I caved: I've adapted https://github.com/thebnich/fennec-adt to work with the existing code for building Fennec.

It's much, much better, for two reasons:
* we get finer grained control over re-building when inputs change;
* we get more powerful output logging and error marking.

The in-tree code to support this is pretty minimal; this ticket tracks adding that code.  We'll deal with testing the Eclipse plugin somewhere else.
Flagging bnicholson and/or rnewman for review, although this isn't
quite ready.  I'll push my plugin repo, give you steps to test, and
post a screencast.
Attachment #8444815 - Flags: review?(rnewman)
Attachment #8444815 - Flags: review?(bnicholson)
Comment on attachment 8444815 [details] [diff] [review]
Part 3: Call Eclipse builder plugin before Android build steps. r=bnicholson

Review of attachment 8444815 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a bit mixed about going back to a plugin, but I guess we might as well give it a try since there's a pretty minimal impact on the actual codebase.
Attachment #8444815 - Flags: review?(bnicholson) → review+
Comment on attachment 8444815 [details] [diff] [review]
Part 3: Call Eclipse builder plugin before Android build steps. r=bnicholson

Review of attachment 8444815 [details] [diff] [review]:
-----------------------------------------------------------------

Rubberstamp to get this out of my queue, but I'll be happy to test if you can point me to the plugin!
Attachment #8444815 - Flags: review?(rnewman) → review+
Blocks: 1014247
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 33 → mozilla33
You need to log in before you can comment on or make changes to this bug.