Closed Bug 1029346 Opened 6 years ago Closed 6 years ago

Warnings as errors can break PGO builds

Categories

(Firefox Build System :: General, defect)

All
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla33

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

/builds/slave/try-lx-00000000000000000000000/build/gfx/harfbuzz/src/hb-ot-tag.cc:901:1: error: the control flow of function '_ZN2OT11SubstLookup18serialize_ligatureEPNS_22hb_serialize_context_tEjRNS_8SupplierINS_7IntTypeItLj2EEEEERNS3_IjEEjS7_S9_S7_' does not match its profile data (counter 'arcs') [-Werror=coverage-mismatch]
/builds/slave/try-lx-00000000000000000000000/build/gfx/harfbuzz/src/hb-ot-tag.cc:901:1: error: the control flow of function '_ZN2OT11SubstLookup18serialize_ligatureEPNS_22hb_serialize_context_tEjRNS_8SupplierINS_7IntTypeItLj2EEEEERNS3_IjEEjS7_S9_S7_' does not match its profile data (counter 'time_profiler') [-Werror=coverage-mismatch]
/builds/slave/try-lx-00000000000000000000000/build/gfx/harfbuzz/src/hb-ot-tag.cc:901:1: error: the control flow of function '_ZN2OT13LigatureSubst9serializeEPNS_22hb_serialize_context_tERNS_8SupplierINS_7IntTypeItLj2EEEEERNS3_IjEEjS7_S9_S7_' does not match its profile data (counter 'arcs') [-Werror=coverage-mismatch]
/builds/slave/try-lx-00000000000000000000000/build/gfx/harfbuzz/src/hb-ot-tag.cc:901:1: error: the control flow of function '_ZN2OT13LigatureSubst9serializeEPNS_22hb_serialize_context_tERNS_8SupplierINS_7IntTypeItLj2EEEEERNS3_IjEEjS7_S9_S7_' does not match its profile data (counter 'time_profiler') [-Werror=coverage-mismatch]
/builds/slave/try-lx-00000000000000000000000/build/gfx/harfbuzz/src/hb-ot-tag.cc:901:1: error: the control flow of function '_ZNK2OT19ChainContextFormat35applyEPNS_18hb_apply_context_tE' does not match its profile data (counter 'arcs') [-Werror=coverage-mismatch]
/builds/slave/try-lx-00000000000000000000000/build/gfx/harfbuzz/src/hb-ot-tag.cc:901:1: error: the control flow of function '_ZNK2OT19ChainContextFormat35applyEPNS_18hb_apply_context_tE' does not match its profile data (counter 'time_profiler') [-Werror=coverage-mismatch]
I've seen similar things in the past with MSVC PGO as well, which is why we still have these gems:
http://hg.mozilla.org/mozilla-central/annotate/e86b84998b18//configure.in#l2170
This relies on the patch from bug 883339 making MOZ_PGO available in configure.
Attachment #8445549 - Flags: review?(ted)
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Review ping.
Flags: needinfo?(ted)
Comment on attachment 8445549 [details] [diff] [review]
Add -Wno-erro to PGO builds

Review of attachment 8445549 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +6824,5 @@
>      MOZ_CXX_SUPPORTS_WARNING(-W, no-error=deprecated-declarations, ac_cxx_has_noerror_deprecated_declarations)
> +
> +    if test -n "$MOZ_PGO"; then
> +        MOZ_C_SUPPORTS_WARNING(-W, no-error=coverage-mismatch, ac_c_has_noerror_coverage_mismatch)
> +        MOZ_CXX_SUPPORTS_WARNING(-W, no-error=coverage-mismatch, ac_c_has_noerror_coverage_mismatch)

Wonder if we shouldn't make a meta-macro that does both MOZ_{C,CXX}_SUPPORTS_WARNING so we can stop repeating ourselves.
Attachment #8445549 - Flags: review?(ted) → review+
Flags: needinfo?(ted)
https://hg.mozilla.org/mozilla-central/rev/c9f4c0254099
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.