1029448 - Copy improvements when downloading DRM content

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Beatriz Rodríguez [:brg]]

Attachment: 2014-06-24-04-45-13.png

When downloading DRM content (out of download manager control) the user can see first a downloading progress bar while the content is being downloaded.

When the download is finished, the user will see the popup question in the attachment: "Do you want to download and install this audio file as a song or as a ringtone?"

However the content is already downloaded. IMHO this question should be simpler:
"Do you want to install this audio file as a song or as a ringtone?

Comment 1

[Guillermo López :willyaranda (probably SLOW response)]

ni from Matej, as I think he is in charge of copy team.

Comment 2

[Matej Novak [:matej]]

The suggestion in comment 0 looks good to me. Thanks.

Comment 3

[David Garcia [:davidg][retired]]

Attachment: github PR

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8453655 [details] [review]
github PR

I don't see anything l10n related, why the f?

Comment 5

[David Garcia [:davidg][retired]]

Sorry Francesco, I'm new in gaia and I don't know the process very well.
I changed one of the locales in english (removed some words).
So, I was told I should rename the key in the locale file, that way the translation team will know they need to translate it to the rest of the languages.
They told me to put [e-mail] in review as well. Is it needed?

Comment 6

[Francesco Lodolo [:flod]]

(In reply to David Garcia [:davidg] from comment #5)
> Sorry Francesco, I'm new in gaia and I don't know the process very well.
No problem.

> I changed one of the locales in english (removed some words).
> So, I was told I should rename the key in the locale file, that way the
> translation team will know they need to translate it to the rest of the
> languages.
That's perfect: new string, new ID.

> They told me to put [e-mail] in review as well. Is it needed?
It's not needed. You need feedback from l10n only if you have doubts about the structure or localizability, not about copy, not to warn about new strings ;-)

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8453655 [details] [review]
github PR

Redirecting to our l10n folks.

Comment 8

[Staś Małolepszy :stas]

Comment on attachment 8453655 [details] [review]
github PR

Looks good to land on master, assuming this string is not used in cases where the download hasn't been initiated yet.  r=me, thanks for the patch!

Comment 9

[Francesco Lodolo [:flod]]

Marking as checkin-needed, I don't think David has commit access.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/196c531a35b97f78ff80c2a787d050be7f3896d8

Comment 11

[Juanjo Iglesias]

I have tested using a Flame master, today build (Gecko c431020 and Gaia 1c9eb3d), and its working fine.

When the download is finished, the user see the popup "Do you want to install this audio file as a song or as a ringtone?"

Add screenshot to see it.

Comment 12

[Juanjo Iglesias]

Attachment: screenshot_drm_install.png