Copy improvements when downloading DRM content

VERIFIED FIXED in Firefox OS v2.1

Status

Firefox OS
Gaia
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: brg, Assigned: davidg)

Tracking

unspecified
2.0 S6 (18july)
All
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v2.1 fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

4 years ago
Created attachment 8445054 [details]
2014-06-24-04-45-13.png

When downloading DRM content (out of download manager control) the user can see first a downloading progress bar while the content is being downloaded.

When the download is finished, the user will see the popup question in the attachment: "Do you want to download and install this audio file as a song or as a ringtone?"

However the content is already downloaded. IMHO this question should be simpler:
"Do you want to install this audio file as a song or as a ringtone?
ni from Matej, as I think he is in charge of copy team.
Flags: needinfo?(Mnovak)

Comment 2

4 years ago
The suggestion in comment 0 looks good to me. Thanks.
Flags: needinfo?(Mnovak)
(Assignee)

Updated

4 years ago
Assignee: nobody → david.garciaparedes
(Assignee)

Comment 3

4 years ago
Created attachment 8453655 [details] [review]
github PR
Attachment #8453655 - Flags: review?(dflanagan)
Attachment #8453655 - Flags: feedback?
(Assignee)

Updated

4 years ago
Attachment #8453655 - Flags: feedback? → feedback?(l10n)
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Keywords: checkin-needed
Comment on attachment 8453655 [details] [review]
github PR

I don't see anything l10n related, why the f?
Attachment #8453655 - Flags: feedback?(l10n)
(Assignee)

Comment 5

4 years ago
Sorry Francesco, I'm new in gaia and I don't know the process very well.
I changed one of the locales in english (removed some words).
So, I was told I should rename the key in the locale file, that way the translation team will know they need to translate it to the rest of the languages.
They told me to put l10n@mozilla.com in review as well. Is it needed?
(In reply to David Garcia [:davidg] from comment #5)
> Sorry Francesco, I'm new in gaia and I don't know the process very well.
No problem.

> I changed one of the locales in english (removed some words).
> So, I was told I should rename the key in the locale file, that way the
> translation team will know they need to translate it to the rest of the
> languages.
That's perfect: new string, new ID.

> They told me to put l10n@mozilla.com in review as well. Is it needed?
It's not needed. You need feedback from l10n only if you have doubts about the structure or localizability, not about copy, not to warn about new strings ;-)
(Assignee)

Updated

4 years ago
Attachment #8453655 - Flags: review?(dflanagan) → review?(21)
Comment on attachment 8453655 [details] [review]
github PR

Redirecting to our l10n folks.
Attachment #8453655 - Flags: review?(21) → review?(stas)
Comment on attachment 8453655 [details] [review]
github PR

Looks good to land on master, assuming this string is not used in cases where the download hasn't been initiated yet.  r=me, thanks for the patch!
Attachment #8453655 - Flags: review?(stas) → review+
Marking as checkin-needed, I don't think David has commit access.
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/196c531a35b97f78ff80c2a787d050be7f3896d8
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.1: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)

Comment 11

4 years ago
I have tested using a Flame master, today build (Gecko c431020 and Gaia 1c9eb3d), and its working fine.

When the download is finished, the user see the popup "Do you want to install this audio file as a song or as a ringtone?"

Add screenshot to see it.

Comment 12

4 years ago
Created attachment 8459491 [details]
screenshot_drm_install.png
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.