1029449 - mozregression shouldn't download full build to get complete revision information

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[:Gijs (he/him)]

In some cases, mozregression needs the cset information for a given day, rather than actually wanting to have the user check whether the issue they're checking for reproduces or not. In this case it downloads a full build.

Each directory also has a small text file in it, e.g. http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/06/2014-06-22-03-02-03-mozilla-central/firefox-33.0a1.en-US.linux-i686.txt which has the cset information. Instead of downloading the full archive (which weighs in at 80mb on mac these days), mozregression should download only the text file if all it needs is the cset info.

Comment 1

[:Gijs (he/him)]

In particular, it says:

Got as far as we can go bisecting nightlies...
Ensuring we have enough metadata to get a pushlog...
Downloading build from: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/06/2014-06-19-03-02-03-mozilla-central/firefox-33.0a1.en-US.mac.dmg

which is sadmaking.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The appropriate code is located here:
https://github.com/mozilla/mozregression/blob/master/mozregression/regression.py#L163

Comment 3

[William Lachance (:wlach)]

(In reply to Henrik Skupin (:whimboo) from comment #2)
> The appropriate code is located here:
> https://github.com/mozilla/mozregression/blob/master/mozregression/
> regression.py#L163

Yes, and more specifically the code that's downloading nightly builds just to get an inbound revision is here:

https://github.com/mozilla/mozregression/blob/master/mozregression/regression.py#L70

We should probably just create a function which downloads the metadata and processes it accordingly. This is not completely trivial, but would make a good bug for (1) someone who had just finished a good first bug or (2) someone looking for something to do on a rainy afternoon. ;)

Comment 4

[Julien Pagès (:parkouss)]

(In reply to William Lachance (:wlach) from comment #3)
> We should probably just create a function which downloads the metadata and
> processes it accordingly. This is not completely trivial, but would make a
> good bug for (1) someone who had just finished a good first bug or (2)
> someone looking for something to do on a rainy afternoon. ;)

I could be the one, for (1) and (2). :) But I will need some infos in order to do it - how can I retrieve metadata without downloading the whole file ?

If you can help me on this William, you can assign me on this bug - I will be happy to do it.

Comment 5

[Julien Pagès (:parkouss)]

Well I didn't read carefully the comment #0 - I know now how to get the required metadata.

Comment 6

[Julien Pagès (:parkouss)]

Attachment: mozregression should print gaia regression pushlog information for b2g

Comment 7

[William Lachance (:wlach)]

Comment on attachment 8446982 [details] [review]
mozregression should print gaia regression pushlog information for b2g

This looks good, however we also unnecessarily download a build to get the first inbound revision here:

https://github.com/mozilla/mozregression/blob/master/mozregression/regression.py#L174

Could you fix that part to use your new function? Other than that this is great, thanks!

Comment 8

[William Lachance (:wlach)]

(In reply to William Lachance (:wlach) from comment #7)
> Comment on attachment 8446982 [details] [review]
> mozregression should print gaia regression pushlog information for b2g
> 
> This looks good, however we also unnecessarily download a build to get the
> first inbound revision here:
> 
> https://github.com/mozilla/mozregression/blob/master/mozregression/
> regression.py#L174
> 
> Could you fix that part to use your new function? Other than that this is
> great, thanks!

Oh also, it would be great if you could reference this bug in the commit message like this:

Bug 1029449 - Don't download builds just to get revision metadata

(or something similar)

Comment 9

[Julien Pagès (:parkouss)]

Sure ! I missed that part. :)

I will wait until the patch for Bug 1030314 is landed because otherwise it will conflicts, then post a new attachment pull request link.

Comment 10

[William Lachance (:wlach)]

Merged this. Thanks!!