Closed Bug 1029459 Opened 10 years ago Closed 9 years ago

[rule view] Missing color swatches in linear-gradient multiple background

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: pbro, Assigned: tromey)

References

Details

Attachments

(1 file)

remove output-parser iteration limit
6.47 KB, patch
pbro
: review+
Details | Diff | Splinter Review 
STR:
- Open this page: http://jsbin.com/nizaxehi/1
- Open the inspector
- Inspect the <body> node
=> The background property value in the rule-view shows color swatches before each color value, except the last 2.
This has been fixed in 40.1.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
http://codepen.io/joewalker/pen/QjGEzR

Inspect the first colour square - it appears we give up after 18 colors.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
This trips across the "max iteration" code in output-parser:

https://dxr.mozilla.org/mozilla-central/source/devtools/shared/output-parser.js#172
I have a patch.
I think removing the iteration limit is probably the best thing to do.
Assignee: nobody → ttromey
Status: REOPENED → ASSIGNED
Attachment #8666827 - Flags: review?(pbrosset)
Attachment #8666827 - Flags: review?(pbrosset) → review+
The test depends on some changes in the as-authored patch, and I'd rather
not rebase it earlier at this point.
Depends on: 984880
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fca7109258f4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago → 9 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: