1029528 - Display "Thanks for signing up" modal on party.wmkr.org after conversion from welcome.wmkr.org

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Jon Buckley [:jbuck]]

After a user signs up on welcome.wm.o, we should present a "Thanks for signing up" modal on party.wm.o.

Comment 1

[Matt Thompson (@OpenMatt :OpenMatt)]

* This one's blocking final QA.

Comment 2

[Jon Buckley [:jbuck]]

Kate's on it

Comment 3

[inactivate account for kate]

Attachment: https://github.com/mozilla/makerparty/pull/26

Comment 4

[inactivate account for kate]

Attachment: http://recordit.co/RVHrPrxbrf.gif

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/makerparty

https://github.com/mozilla/makerparty/commit/efa2880feee89a956e19fd43d1fb2859ce79f8a0
Bug 1029528 - Modal for thanks for signing up

Comment 6

[Jon Buckley [:jbuck]]

This got backed out in https://github.com/mozilla/makerparty/pull/27/files due to it disabling all click handlers on the page

Comment 7

[Andrea Wood [:andreawood]]

Comment on attachment 8445488 [details]
http://recordit.co/RVHrPrxbrf.gif

This looks good!

Comment 8

[inactivate account for kate]

Attachment: https://github.com/mozilla/makerparty/pull/30

This is the fixed version of the modal

Comment 9

[Andrea Wood [:andreawood]]

Hi, can you let me know ETA on this going live? The Firefox snippet team is at-the-ready to deploy our snippet tests. We need to get this up, working, and QA the user flow still today. Thanks for your help!

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/makerparty

https://github.com/mozilla/makerparty/commit/b9586293062aa8ee2cbecebec217cfe38ee9d71e
Bug 1029528 - Modal for thanks for signing up (with fixes)

Comment 11

[Mavis Ou [:mavis]]

PR is merged.  Pushing it to production now.  Will update the bug once it's live.

Comment 12

[Jon Buckley [:jbuck]]

Invalidating / and /js/ui.js now, should be live in 15 minutes.

Comment 13

[Andrea Wood [:andreawood]]

hey guys, i just tried it out on Firefox and the screen darkened slightly, but no modal. Can you QA, fix, and make sure it's working? This has delayed us over 24 hrs.....

Comment 14

[Jon Buckley [:jbuck]]

Current status: I cannot for the life of me invalidate the root from the CDN. I'm currently seeing if I can switch party.webmaker.org to point directly at Heroku

Comment 15

[Jon Buckley [:jbuck]]

Current status: I am dumb, and I should've tried this before, but with mavis' help we are golden!

https://party.webmaker.org/?thanks=mavis

Comment 16

[Andrea Wood [:andreawood]]

Great! I'm doing some final QA now and alerting JP that he should watch load on that page. Thanks everyone!