1029568 - Software Home button does not work as expected with the rocketbar opened

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Very similar to bug 968382, the z-index of the software home button is below the rocketbar results, and so it does not receive all the input events it is supposed to received and never triggers a 'home' event.

The result is the search result from the rocketbar living on top of the homescreen as a second overlay (same symptom than bug 1028661 but different cause).

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug1029568.patch

Comment 2

[Preeti Raghunath(:Preeti)]

Backlog for now.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Preeti Raghunath(:Preeti) from comment #2)
> Backlog for now.

That seems wrong. Re-asking as the symptom are the exact same on than one of the 2.0+ blocker. Reasking.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #3)
> (In reply to Preeti Raghunath(:Preeti) from comment #2)
> > Backlog for now.
> 
> That seems wrong. Re-asking as the symptom are the exact same on than one of
> the 2.0+ blocker. Reasking.

Software home button isn't used by any production device that ships right now, so that's why this was marked as a non-blocker. When the software home button becomes a partner-driven requirement, then we can start evaluating these bugs for a blocking decision. Until then, we don't have a reason to hold a release on a software home button bug.

Comment 5

[Jason Smith [:jsmith]]

Does comment 4 make sense? If not, can you clarify your perspective a bit more?

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Jason Smith [:jsmith] from comment #5)
> Does comment 4 make sense? If not, can you clarify your perspective a bit
> more?

I understand the rationale behind the decision, so that's fine :)

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #6)
> (In reply to Jason Smith [:jsmith] from comment #5)
> > Does comment 4 make sense? If not, can you clarify your perspective a bit
> > more?
> 
> I understand the rationale behind the decision, so that's fine :)

Fwiw I bet that a lot of duplicates will be opened afterward ;)

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8445233 [details] [diff] [review]
bug1029568.patch

Alive is on vacation! Redirecting the review to Kevin.

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8445233 [details] [diff] [review]
bug1029568.patch

Review of attachment 8445233 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to work fine, thanks!

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=8b79ca75dc05df61f6f85ffb4b33c6c379ba7b69

Comment 11

[Jason Smith [:jsmith]]

(In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #6)
> (In reply to Jason Smith [:jsmith] from comment #5)
> > Does comment 4 make sense? If not, can you clarify your perspective a bit
> > more?
> 
> I understand the rationale behind the decision, so that's fine :)

Ok, I'll move this to backlog then.

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/7d99acb6e41a990f4a041df6c06d80c1dc8fa8a7