1029609 - [Homescreen] Black screen shown during loading when adding a smart collection

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Tony Chung [:tchung]]

Attachment: logcat

Right now, if you try to add a smart collection and there's a delayed load, the user just sees a black screen.   No throbber, no loading message, just a black screen.   We need some kind of placeholder performance bar or page that gives the user a better performance perception than just a black screen.

See screencast:  http://youtu.be/1i-ECpzBlVE

Also, logcat attached.

Repro
1) install 2.0 aurora on Flame (20140624000201)

Gaia      9d2f7bd16a8dc0c74c97c5a40d2f0731f3dfff4b
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/f118b45daada
BuildID   20140624000201
Version   32.0a2
ro.build.version.incremental=109

2) on homescreen, long tap and click "Add smart collections"
3) when the list appears, pick one category to add (ie. Sports)
4) Verify a black screen appears while the page is loading, with no performance indication or progress bar.

Expected:
- some sort of perceptive loading page to indicate the user to wait , it's loading

ActuaL:
- just a black screen, making it feel weird.

Comment 1

[Tony Chung [:tchung]]

ni UX team for feedback

Comment 2

[James Lal [:lightsofapollo]]

Probably won't end up fixing this in the next few hours.

Comment 3

[Stephany Wilkes]

Flagging Rob but my initial response is to say that this should follow the established pattern (spinner).

Comment 5

[Kevin Grandon :kgrandon]

Some notes here: https://bugzilla.mozilla.org/show_bug.cgi?id=1028452#c22

I feel that we should re-measure this once we solve the geolocation issue in bug 1028452 - it might just fix this, or make it a lot better.

Comment 6

[Aus Lacroix [:aus]]

Attachment: Pull Request - Show spinner when loading new collections

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8447440 [details] [review]
Pull Request - Show spinner when loading new collections

I think we can probably do better, but a more comprehensive fix for 2.0 can bring a lot of risk. I think we should land this for now as it least gives the user some progress indicator.

I'm also going to upload a screenshot and ask for ui-review? to see if this is acceptable for 2.0.

Comment 8

[Kevin Grandon :kgrandon]

Attachment: Spinner during create

Jacqueline - here is a screenshot of the treatment we now apply after selecting a collection to create. It is the same spinner as when you are entering the create collection screen, before we load the list of suggested collections.

We are unfortunately unable to change the text of the dialog at this time due to the string freeze. Do you think this is an acceptable approach for 2.0?

Comment 9

[Kevin Grandon :kgrandon]

Gaia-try seemed to not want to run for some reason, but I am verifying all tests locally and this one is simple so landing: https://github.com/mozilla-b2g/gaia/commit/4eea9b9fb0adac7573a2d7afa5e12cb33d952573

Comment 10

[Jacqueline Savory [:jsavory] UX]

Comment on attachment 8447456 [details]
Spinner during create

I think this screen will work fine for 2.0.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/f9cc46b5006cd356dd647ba3edbc34eb8711d089

Comment 12

[Rob MacDonald [:robmac]]

Will defer to Jacqueline as per comment 10. Thanks!

Comment 13

[Elie]

Attachment: VIDEO0115_Compress.MP4

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2