Closed
Bug 1029610
Opened 10 years ago
Closed 7 years ago
Discard all xul reftest on B2G
Categories
(Testing :: Reftest, defect)
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: u459114, Assigned: u459114)
Details
Attachments
(1 file)
We don't support XUL loading on B2G. Currently, we manually add skip-if(B2G) failure type to each xul test case There are two drawbacks 1. If a developer adds any new xul test case, we need to remember add skip-if, otherwise, orange get. That developer need to figure out what's going on on B2G, and blah blah... it's totally a time wasting from my perspective. 2. bug 996183 and Bug 1029348 are both discussing about creating statistic report for reftest. skip-if(B2G) may mislead analysis result. As a result, I am thinking of disable xul reftest in reftest.js on B2G by default, so that we don't need to manually add skip-if in lists of reftest
Updated•10 years ago
|
OS: Windows 7 → Gonk (Firefox OS)
Hardware: x86_64 → All
Comment 1•7 years ago
|
||
http://searchfox.org/mozilla-central/source/layout/forms/test/mochitest.ini#58 I just searched skip-if + b2g and this is the only thing I can find; everything seems to be eliminated in previous bugs. Cj, would you mind taking out this line?
Flags: needinfo?(cku)
Comment hidden (mozreview-request) |
Attachment #8889472 -
Flags: review?(pyang)
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8889472 [details] Bug 1029610 - Remove b2g skip-if in forms/test/mochitest.ini. https://reviewboard.mozilla.org/r/160502/#review166014 No concern since b2g has entirely removed in m-c. Please trigger another try by latest m-c.
Attachment #8889472 -
Flags: review?(pyang) → review+
Pushed by cku@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/13e18ee3e49a Remove b2g skip-if in forms/test/mochitest.ini. r=pyang
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/13e18ee3e49a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•