Discard all xul reftest on B2G

RESOLVED FIXED in Firefox 56

Status

defect
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: u459114, Assigned: u459114)

Tracking

unspecified
mozilla56
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

5 years ago
We don't support XUL loading on B2G.

Currently, we manually add skip-if(B2G) failure type to each xul test case

There are two drawbacks 
1. If a developer adds any new xul test case, we need to remember add skip-if, otherwise, orange get. That developer need to figure out what's going on on B2G, and blah blah... it's totally a time wasting from my perspective. 
2. bug 996183 and Bug 1029348 are both discussing about creating statistic report for reftest. skip-if(B2G) may mislead analysis result.

As a result, I am thinking of disable xul reftest in reftest.js on B2G by default, so that we don't need to manually add skip-if in lists of reftest
OS: Windows 7 → Gonk (Firefox OS)
Hardware: x86_64 → All
http://searchfox.org/mozilla-central/source/layout/forms/test/mochitest.ini#58
I just searched skip-if + b2g and this is the only thing I can find; everything seems to be eliminated in previous bugs.

Cj, would you mind taking out this line?
Flags: needinfo?(cku)
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Attachment #8889472 - Flags: review?(pyang)
Assignee

Updated

2 years ago
Assignee: nobody → cku
Flags: needinfo?(cku)
Comment hidden (mozreview-request)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8889472 [details]
Bug 1029610 - Remove b2g skip-if in forms/test/mochitest.ini.

https://reviewboard.mozilla.org/r/160502/#review166014

No concern since b2g has entirely removed in m-c.
Please trigger another try by latest m-c.
Attachment #8889472 - Flags: review?(pyang) → review+

Comment 5

2 years ago
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/13e18ee3e49a
Remove b2g skip-if in forms/test/mochitest.ini. r=pyang

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/13e18ee3e49a
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.