Closed
Bug 1029622
Opened 10 years ago
Closed 10 years ago
Latin1 strings: convert ctypes
Categories
(Core :: js-ctypes, defect)
Core
js-ctypes
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
20.82 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
There's a lot of cruft here, I'm just making the changes to get it to work without touching anything else. Also, the style is a mix of Gecko and SpiderMonkey style; I tried to match the surrounding code but it's a mess.
Attachment #8445268 -
Flags: review?(terrence)
Comment 1•10 years ago
|
||
Comment on attachment 8445268 [details] [diff] [review] Patch Review of attachment 8445268 [details] [diff] [review]: ----------------------------------------------------------------- CTypes is incredibly useful; I wish we had some slack in the schedule to clean it up.
Attachment #8445268 -
Flags: review?(terrence) → review+
Comment 2•10 years ago
|
||
(In reply to Terrence Cole [:terrence] from comment #1) > CTypes is incredibly useful; I wish we had some slack in the schedule to > clean it up. Is there a bug for that? (Sorry for OT)
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc6859ffcd20 Try: https://tbpl.mozilla.org/?tree=Try&rev=7505ee6593b5
https://hg.mozilla.org/mozilla-central/rev/fc6859ffcd20
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•