Closed Bug 1029632 Opened 6 years ago Closed 6 years ago
Fix Up URI leaks Preference observers via Add Bool Var Cache
This was noticed in bug 982428, and I'm trying to ensure this never happens again in bug 1029509. In any case, because bug 982428 changes interfaces and isn't entirely risk-free uplift isn't straightforward. Whatever we end up doing there, we should definitely ensure that we fix the leakiness for 31/32.
Patch against beta
Attachment #8445292 - Flags: review?(bzbarsky)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
(applies cleanly to aurora as well)
Comment on attachment 8445292 [details] [diff] [review] prevent leaks through adding pref cache, r=me
Attachment #8445292 - Flags: review?(bzbarsky) → review+
Comment on attachment 8445292 [details] [diff] [review] prevent leaks through adding pref cache, [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 935377 User impact if declined: (very) slow leakage as people use the browser Testing completed (on m-c, etc.): local, has automated tests. Basically just a very small part of the patch for bug 982428, purely to counter the leakage that we uncovered. Risk to taking this patch (and alternatives if risky): very low because of automated tests for this particular feature of the code String or IDL/UUID changes made by this patch: none
(In reply to :Gijs Kruitbosch from comment #4) > Testing completed (on m-c, etc.): local, has automated tests. Basically just > a very small part of the patch for bug 982428, purely to counter the leakage > that we uncovered. To be clear, this is essentially in lieu of uplifting bug 982428, which means I'm not intending to land this on fx-team / m-c.
Marco, can you add this as well? Thanks!
Added to Iteration 33.2
You need to log in before you can comment on or make changes to this bug.