1029695 - [rule view] Need null check for ruleview-propertyvalue query in getParentTextProperty

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Screenshot

STR:
1. Have a rule with no properties
2. Click to add properties
3. Move the mouse around the input box.
4. Observe console error for parent.querySelector(...) is null

rule-view#getParentTextProperty(node) needs a check to make sure .ruleview-propertyvalue exists or not and returns null as necessary.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: test.html

Attached a test page

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: parentTextFix.patch

Comment 3

[Heather Arthur [:harth]]

Comment on attachment 8445336 [details] [diff] [review]
parentTextFix.patch

Review of attachment 8445336 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/styleinspector/rule-view.js
@@ +2860,5 @@
>   * @return {TextProperty}
>   */
>  function getParentTextProperty(node) {
>    let parent = getParentTextPropertyHolder(node);
> +  if (!parent || !parent.querySelector(".ruleview-propertyvalue")) {

instead of querySelectoring twice, cache it in a var, like:

var propValue = parent.querySelector(".ruleview-propertyvalue");
if (propValue) {
  return propValue.textProperty;
}
return null;

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: parentTextFix.patch

https://tbpl.mozilla.org/?tree=Try&rev=07862b0133c0

I separated out the check for propValue since we want to make sure the parent isn't null first before doing querySelector.

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: parentTextFix.patch

Added r=harth to commit msg

Comment 6

[Heather Arthur [:harth]]

Comment on attachment 8446247 [details] [diff] [review]
parentTextFix.patch

Review of attachment 8446247 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/328c548bb116

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/328c548bb116