1029696 - Add comment "+" sign not showing up on Github with Firefox 30.0 on Mac OSX 10.9.3

Status: RESOLVED DUPLICATE of bug 980075

(Firefox :: Untriaged, defect, P2)

Description

[woshiadai2007]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140605174243

Steps to reproduce:

Install Firefox 30.0 on Mac OSX, go visit any github project pull request, the file changed view that lists all the changes/diffs.


Actual results:

normally you can see a + sign to allow you to comment on the lines, but with this particular FF version, the + sign is not shown, thus prevent users from commenting.

Tried the same steps with Safari and Chrome, they both worked fine.


Expected results:

+ sign should show up and allow the user to make comments on the changes.

Comment 1

[Charly Molter :lahabana]

Attachment: FF screenshot

Comment 2

[Charly Molter :lahabana]

Attachment: Safari Screenshot

Here is 2 screenshots that show how it is displayed in Safari and in FF you can see that the blue box does not appear.
You can't click to add a comment

Comment 3

[Charly Molter :lahabana]

This seems to be fixed on github.com but still present on my github enterprise it's probably a different version.

Comment 4

[Charly Molter :lahabana]

Happens it's a duplicate.

Here's a work around though:
In the meantime, you can workaround this by using an alternate browser like Chrome or your users can add the following to their userContent.css files:

@-moz-document url-prefix(http(s)://[hostname]) 
{ 
  .file .highlight { 
    overflow: visible !important; 
  } 
}

Comment 5

[woshiadai2007]

Hi, Charly

I'm on a Mac, created a chrome directory inside the profile directory, something like ~/Library/Application Support/Firefox/Profiles/e24mem95.default/chrome, then created a userContent.css with the content you provided.

Still does not work for me. You sure this workaround works? Or the path to change userContent.css is not right?

Comment 6

[Charly Molter :lahabana]

This comes from github support. I haven't checked if it works though.

However, I was thinking of just putting this snippet it in the page with the inspector.