1029702 - TypedObjectPrediction.cpp:332:13: warning: overflow in implicit constant conversion [-Woverflow]

Status: RESOLVED DUPLICATE of bug 1029126

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

New build warning, with GCC (version 4.9) on 64-bit Ubuntu 14.04:
{
js/src/jit/TypedObjectPrediction.cpp:332:13: warning: overflow in implicit constant conversion [-Woverflow]
      *offset = SIZE_MAX;
              ^
}
Link to source:
http://hg.mozilla.org/mozilla-central/annotate/e86b84998b18/js/src/jit/TypedObjectPrediction.cpp#l332

"offset" is a pointer to a int32_t, so SIZE_T is too large for it, both on 64-bit and 32-bit systems.

Presumably either offset should have type size_t*, or we should be using INT32_MAX or whatever the appropriate name is.

Niko, can you take this and apply whatever fix matches your intent about what should be happening here?

Comment 1

[Daniel Holbert [:dholbert]]

> "offset" is a pointer to a int32_t, so SIZE_T is too large for it

(er, meant to say "SIZE_MAX is too large for it")