1029741 - Project Editor: Prompt before reloading if a file has unsaved changes inside of editor and it has changed on disk

Status: RESOLVED INVALID

(DevTools Graveyard :: WebIDE, defect, P3)

Description

[Brian Grinstead [:bgrins]]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1011031#c5

We should only auto-reload the editor if there are no unsaved changes.  Otherwise we should prompt before reloading.

Comment 1

[Jakub Pýcha]

Hello,

I am new in the open source world. I would like to contribute into Firefox Web IDE. 
Can i do this issue? Can you tell me how i can started?

I am following instruction in https://developer.mozilla.org/en-US/docs/Introduction and preparing my developing environment.

Thank you for your guidance.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Sorry for the delay, I was out last week.

In general, check out our Hacking page[1] to get started with the codebase.

For this particular issue, we'd like to modify WebIDE's detection of external changes so that we show a prompt if WebIDE's copy is also modified.

However, when I test locally, it seems we're no longer noticing external file changes at all!  Brian, any guess what may have changed since you landed bug 1011031?  I can try to look in a bit if you busy, but just thought you may have a guess.

[1]: https://wiki.mozilla.org/DevTools/Hacking

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to J. Ryan Stinnett [:jryans] from comment #2)
> However, when I test locally, it seems we're no longer noticing external
> file changes at all!  Brian, any guess what may have changed since you
> landed bug 1011031?  I can try to look in a bit if you busy, but just
> thought you may have a guess.

Just tested locally, and I believe things are working as they always have:

Open file1.txt in WebIDE
Open file2.txt in WebIDE
Edit file1.txt in external editor
Open file1.txt in WebIDE -> New contents loaded

I'm guessing you were expecting the contents to automatically change while file1.txt was still selected in WebIDE, but that won't be reasonable until we have FS.watch.  Well, maybe we could hack it by waiting for the window to be focused and trying to reload, but we should wait until this bug is done before doing that to prevent losing changes.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1011031#c2 for more info.

Comment 4

[Julian Descottes [:jdescottes]]

WebIDE triage. Filter on TRIAGE-JD201705

Comment 5

[Patrick Brosset <:pbro>]

Projecteditor was removed from the tree in bug 1361311.