Closed Bug 1029766 Opened 6 years ago Closed 6 years ago
Intermittent TEST-UNEXPECTED-FAIL | collection
_test .js | Vertical - Collection drag icon (/w entry point) into collection
One of the verticalhome gaia-integration tests is frequently failing on TBPL, preventing us from unhiding it there: 10:09:33 INFO - TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/verticalhome/test/marionette/collection_test.js | Vertical - Collection drag icon (/w entry point) into collection https://tbpl.mozilla.org/php/getParsedLog.php?id=42373215&tree=B2g-Inbound&full=1#error0
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Adding some waits here, going to run a bunch on gaia-try to see what it does.
Comment on attachment 8445474 [details] [review] Pull request Ok, I think I finally have this one fixed. https://tbpl.mozilla.org/?tree=Gaia-Try&rev=a1e0c4034c340f02d3d733a43c66f2d1827e721a It seems that calling move() with the nature of our vertical homescreen scrolling during the drag drop is quite tricky, so waiting for the screen to scroll to the bottom seems to address this issue. The alternative might be to have a whole lot of executeScript() to manually position the collection near the top. James - can you think of anything better? Thanks!
Attachment #8445474 - Flags: review?(jlal)
Comment on attachment 8445474 [details] [review] Pull request Looks good but also looks like we have different intermittent failures we also need to fix https://github.com/mozilla-b2g/gaia/commit/3dd9c3487ae8347178e4941bbbb6cc229d414606
Attachment #8445474 - Flags: review?(jlal) → review+
Looks like this landed: https://github.com/mozilla-b2g/gaia/commit/3dd9c3487ae8347178e4941bbbb6cc229d414606
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S5 (4july)
This test has started failing quite frequently on TBPL, investigate... https://tbpl.mozilla.org/php/getParsedLog.php?id=43117566&tree=B2g-Inbound I am restarting Gi on the following jobs to verify: Suspected breakage by: https://tbpl.mozilla.org/?tree=B2g-Inbound&showall=1&rev=9c2a35a07a0e Previous run: https://tbpl.mozilla.org/?tree=B2g-Inbound&showall=1&rev=3e22f3cb063e
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 2.0 S5 (4july) → 2.0 S6 (18july)
Disabled in: https://github.com/mozilla-b2g/gaia/commit/f1e56e1e1f9a9904f2bc29d07c00b2713152c29d Leave-open added so sheriffs won't resolve.
Comment on attachment 8453559 [details] [review] Pull request - additional wait I think I finally have this test solved. Could one of you guys take a look if you have a chance? Thanks!
Comment on attachment 8453559 [details] [review] Pull request - additional wait I am wondering what happen if we receive the "updated" event later than https://github.com/mozilla-b2g/gaia/pull/21563/files#diff-69eee4fffc909dcb63f98521f692be25R70? If you tested that it does not happen you could remove the listener at the end of prependAsyncItems method thought.
Comment on attachment 8453559 [details] [review] Pull request - additional wait LGTM, awesome work as usual
Attachment #8453559 - Flags: review+
Comment on attachment 8453559 [details] [review] Pull request - additional wait Upps, sorry , I deleted the Amir's review
Comment on attachment 8453559 [details] [review] Pull request - additional wait (In reply to Cristian Rodriguez (:crdlc) from comment #14) > Comment on attachment 8453559 [details] [review] > Pull request - additional wait > > Upps, sorry , I deleted the Amir's review No, I think that was me :) I just wanted to see who could get to it first. Thanks!
2.0: (a=test only) https://github.com/mozilla-b2g/gaia/commit/b7dd1f0c3142d58691bb46b35f094dbb0b00d83f
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
Reverted and re-landed for invalid JSON (merge error, sorry about that) https://github.com/mozilla-b2g/gaia/commit/32af89ab91fda0c9536a36a270d831c9a6a0fe5b 2.0 fix: https://github.com/mozilla-b2g/gaia/commit/c46fbcbb943407ca08df1a5ad753e4a3d436cec5
Removing leave-open keyword from resolved bugs, per :sylvestre.
You need to log in before you can comment on or make changes to this bug.