1029769 - Put feed item preview in the main content area, fixed on the right side of the form.

Status: RESOLVED FIXED

(Marketplace Graveyard :: Curation Tools, defect, P3)

Comment 1

[Kevin Ngo [:ngoke]]

My first suggestion before we started implementing this was to put it in the submission footer.

Comment 2

[Kevin Ngo [:ngoke]]

Just occurred to me that the Feed Builder will also have a preview. This is sort of a dealbreaker for this bug. The Feed Builder has little main content area real estate. For the Feed Builder, the current position is ideal (lots of vertical room to grow, only 320px needed). Unless we want to maintain two different feed preview areas, I should wontfix this.

Comment 3

[Chuck Harmston [:chuck]]

We should talk about ways to make it less awkward, because it's not awesome right now.

Perhaps add an additional <preview width> of padding-right to body, with a min-width media query equal to <preview width> + <content width>, so it can be opened without obscuring the form on sufficiently wide viewports?

We should also hide the preview in views where it doesn't make sense.

Comment 4

[Kevin Ngo [:ngoke]]

Temporary solution pushed:

- sidebar not shown on home page, listing page, feed builder page.
- sidebar defaults to active with ability to toggle off on click

Comment 5

[Davor Spasovski [:spasovski]]

Addressed this via responsiveness and always shown. The previews will appear in the footer if your desktop width can't accommodate the floated to the right approach.

https://github.com/mozilla/transonic/commit/f72ed2e

Comment 6

[Kevin Ngo [:ngoke]]

Have to add a case for Feed Builder.