1029780 - Update hotfix not excluding partner builds

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Gregory Szorc [:gps]]

Paul reported that partner builds aren't being excluded by the hotfix.

I downloaded a partner repack for Yahoo and confirmed this.

The code is currently looking for the char pref "app.partner". However, the only prefs in this build with "partner" in them are "app.partner.yahoo" and "mozilla.partner.id".

I see the choices as:

1) Look for any prefs in the app.partner. branch
2) See if mozilla.partner.id is defined and/or has a value
3) Something else

mconnor: please advise on how to properly identify partner builds.

Comment 1

[Benjamin Smedberg]

UpdateChannel.jsm uses app.partner.* http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/UpdateChannel.jsm#33 and we should probably do the same.

Comment 2

[Gregory Szorc [:gps]]

Makes sense to me. Wasn't sure how sane this approach was. But if UpdateChannel is using it...

Comment 3

[Gregory Szorc [:gps]]

Attachment: Properly check for and exclude partner builds

This is how UpdateChannel.jsm does it.

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/releases/firefox-hotfixes/rev/de957c193904

Comment 5

[Paul Silaghi, QA [:pauly]]

https://people.mozilla.org/~gszorc/hotfix-v20140527.01-qa.xpi
Partner builds are excluded now.
Verified fixed on:
Win XP - Firefox 18.0.2: yahoo en-US, ebay en-US, bing en-US, yahoo es-ES
Win 7 - FF 19 aol en-US, FF 18 mail.ru en-US, FF 20 yahoo-th