Update hotfix not excluding partner builds

VERIFIED FIXED

Status

()

Firefox
General
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Paul reported that partner builds aren't being excluded by the hotfix.

I downloaded a partner repack for Yahoo and confirmed this.

The code is currently looking for the char pref "app.partner". However, the only prefs in this build with "partner" in them are "app.partner.yahoo" and "mozilla.partner.id".

I see the choices as:

1) Look for any prefs in the app.partner. branch
2) See if mozilla.partner.id is defined and/or has a value
3) Something else

mconnor: please advise on how to properly identify partner builds.
Flags: needinfo?(mconnor)

Comment 1

4 years ago
UpdateChannel.jsm uses app.partner.* http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/UpdateChannel.jsm#33 and we should probably do the same.
(Assignee)

Comment 2

4 years ago
Makes sense to me. Wasn't sure how sane this approach was. But if UpdateChannel is using it...
Flags: needinfo?(mconnor)
(Assignee)

Comment 3

4 years ago
Created attachment 8445498 [details] [diff] [review]
Properly check for and exclude partner builds

This is how UpdateChannel.jsm does it.
Attachment #8445498 - Flags: review?(benjamin)
(Assignee)

Updated

4 years ago
Assignee: nobody → gps
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Blocks: 928173

Updated

4 years ago
Attachment #8445498 - Flags: review?(benjamin) → review+
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/releases/firefox-hotfixes/rev/de957c193904
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
https://people.mozilla.org/~gszorc/hotfix-v20140527.01-qa.xpi
Partner builds are excluded now.
Verified fixed on:
Win XP - Firefox 18.0.2: yahoo en-US, ebay en-US, bing en-US, yahoo es-ES
Win 7 - FF 19 aol en-US, FF 18 mail.ru en-US, FF 20 yahoo-th
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.