1029787 - Keep profile information in sticky nav instead of language

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Cassie McDaniel [:cassiemc]]

Attachment: sticky-nav.jpg

When you scroll down on a page like https://webmaker.org/en-US/resources the subnav sticks to the top.

On the top righthand side, the language picker stays while the profile information disappears. I think it would be better if it were the other way around, if the profile information stayed and the language picker disappeared – there is more you can do with the profile dropdown, whereas the language picker is a set-and-forget type of functionality.

Comment 1

[Errietta Kostala [:errietta]]

Attachment: https://github.com/mozilla/webmaker.org/pull/877

Comment 2

[inactivate account for kate]

Comment on attachment 8456434 [details] [review]
https://github.com/mozilla/webmaker.org/pull/877

Looks good!

If this is using the exact same html as the other user bar area, I would suggest abstracting this into a partial with ngInclude, or a creating a custom directive.

If you decide to do that, put it back on me for R

Comment 3

[Errietta Kostala [:errietta]]

Attachment: https://github.com/mozilla/webmaker.org/pull/877

Using a partial now

Comment 4

[inactivate account for kate]

Comment on attachment 8456963 [details] [review]
https://github.com/mozilla/webmaker.org/pull/877

Nice!

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/6b1c61fc4720a539e8831983f33d210e671e63f1
Bug 1029787 Keep profile information in sticky nav

https://github.com/mozilla/webmaker.org/commit/8f8eacc0e0e46d2f793030edba10d58e153e0e36
Merge pull request #877 from errietta/bug1029787

Bug 1029787 Keep profile information in sticky nav