Closed Bug 1029798 Opened 10 years ago Closed 10 years ago

Auto suggest should not add a character space as it makes logins impossible

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

x86
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.0+, b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.0 S6 (18july)
blocking-b2g 2.0+
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: swilkes, Assigned: rudyl)

Details

(Whiteboard: [p=1])

Attachments

(1 file)

This is still an issue in the 2.0 build. Nominating as blocking because this makes Facebook login (and some other logins on mobile websites, etc.) impossible. Twitter, however, does not do this. FB is a good repro and clear example.

* Install the Facebook app.
* Try to enter your user name/email. Start to type. 
* Click the little "x" to dismiss the auto-suggest bar. 
* See a single character space appear in the text box you were typing in before you clicked the little x. 
* Click the backspace to continue typing your user name without a space in it. 
* See auto suggest reappear. 
* Dismiss it again; repeat. 

Expected behavior: Dismissing the Firefox OS auto suggest should not force a space into the word the user is trying to type. This makes it impossible for the user to type the correct word, making it impossible for me to log in to Facebook: auto correct repeatedly changes "Stephany" to "Stephan's" and dismissing it enforces a space in my user name. 

Facebook is one of the main things Firefox OS users all over the world tell us they want to do on their phones. It's a reason (along with YouTube) for getting a smartphone in the first place.
blocking-b2g: --- → 2.0?
QA Wanted to check 1.4.
Keywords: qawanted
This bug repro's on: Flame 2.1 Master, Flame 2.0, Flame 1.4, Flame base v122 , Flame base v121-2, OpenC Master, OpenC 2.0, OpenC 1.4, Buri 2.1 Master, Buri 2.0, Buri 1.4

Actual Result: Dismissing the auto suggest bar by tapping the "X" will add a space into the text field that is unexpected. Backspacing to delete the unwanted space causes the suggestion bar to appear again.

Environmental Variables:
Device: Flame Master
Build ID: 20140625064003
Gaia: 1bcd355855626640b2532f2ccb1f814711f7a6ad
Gecko: da1dbcff9493
Version: 33.0a1 (Master)
Firmware Version: v122
------------------------------------------
Environmental Variables:
Device: Flame 2.0
Build ID: 20140625103007
Gaia: ae8c3876b78de6f1a0b9899ce05826601a42d438
Gecko: 13c4804465d6
Version: 32.0a2 (2.0)
Firmware Version: v122
------------------------------------------
Environmental Variables:
Device: Flame 1.4
Build ID: 20140625000201
Gaia: c9416de14acf9e94ab006619cd2418c768422fcb
Gecko: cddf88f78632
Version: 30.0 (1.4)
Firmware Version: v122
------------------------------------------
Environmental Variables:
Device: Flame 1.3
Build ID: 20140616171114
Gaia: e1b7152715072d27e0880cdc6b637f82fa42bf4e
Gecko: e181a36ebafaa24e5390db9f597313406edfc794
Version: 28.0 (1.3)
Firmware Version: v122
------------------------------------------
Environmental Variables:
Device: Flame 1.3
Build ID: 20140610200025
Gaia: e106a3f4a14eb8d4e10348efac7ae6dea2c24657
Gecko: b637b0677e15318dcce703f0358b397e09b018af
Version: 28.0 (1.3)
Firmware Version: v121-2
------------------------------------------
Environmental Variables:
Device: Open_C Master
Build ID: 20140625064003
Gaia: 1bcd355855626640b2532f2ccb1f814711f7a6ad
Gecko: da1dbcff9493
Version: 33.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
------------------------------------------
Environmental Variables:
Device: Open_C 2.0
Build ID: 20140625103007
Gaia: ae8c3876b78de6f1a0b9899ce05826601a42d438
Gecko: 13c4804465d6
Version: 32.0a2 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
-------------------------------------------
Environmental Variables:
Device: Buri Master
Build ID: 20140625064003
Gaia: 1bcd355855626640b2532f2ccb1f814711f7a6ad
Gecko: da1dbcff9493
Version: 33.0a1 (Master)
Firmware Version: v1.2device.cfg
-------------------------------------------
Environmental Variables:
Device: Buri 2.0
Build ID: 20140625124605
Gaia: c478c43229883cee2afd09c6edb42d29a46cc500
Gecko: 8940337ccb5c
Version: 32.0a2 (2.0)
Firmware Version: v1.2device.cfg
-------------------------------------------
Environmental Variables:
Device: Buri 1.4
Build ID: 20140625101108
Gaia: 4979e8d625aed26ebf2aefbf4c86c9b8412f58ce
Gecko: 223fbb1649f6
Version: 30.0 (1.4)
Firmware Version: v1.2device.cfg
-------------------------------------------
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
Keywords: qawanted
QA Contact: croesch
Not a regression
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmitchell)
Triage believes this should block.
blocking-b2g: 2.0? → 2.0+
This should live in Keyboard component.
--

Stephany, I am not sure why this is a blocker per your description, you could still input your email, say 'stephany@moz', by typing "stephany" and then "@".
You don't have to press [X] to dismiss the the suggestion bar, right?

Please help clarify the steps to reproduce if I take anything wrong.
Thanks.
Component: Gaia::System::Input Mgmt → Gaia::Keyboard
Flags: needinfo?(swilkes)
Yes, Rudy. You have to press x to dismiss the suggestion bar. Did you try my exact repro? I literally cannot type my user name successfully due to the combination of the extra character and auto correct.
Flags: needinfo?(swilkes)
I'll try to provide a patch so that dismissing the suggestion won't output a space.
Thanks.
Assignee: nobody → rlu
Attached file Patch V1
I have a patch here so that we won't append a space character after the the users dismiss the word suggestion.
Will set for review after the CI passes.
Status: NEW → ASSIGNED
Whiteboard: [p=1]
Target Milestone: --- → 2.0 S5 (4july)
Comment on attachment 8447840 [details] [review]
Patch V1

Asking for review since the Travis CI and TBPL have both passed. (The failures on Travis are irrelevant.)

--
David, could you please help review this simple patch as I think you understand the feature best and I cannot find a spec for the dismiss button.

Thanks.
Attachment #8447840 - Flags: review?(dflanagan)
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][lead-review+]
The adding the space behavior was clearly spec'ed out by Carrie. See page 8 of the spec here: https://bug927286.bugzilla.mozilla.org/attachment.cgi?id=8339719

Ironically, the example used to justify this feature is also typing a name. Stephany: if you were typing your name in a text message, I suppose you agree that adding a space would be a nice feature, right?

It seems to me that the real bug here is that we are showing word suggestions on a username or password input field. If this was a Gaia app doing it, I'd say we should fix that app to use inputmode="verbatim" so there would not be any suggestions.

Stephany: also note that if you just ignore the Stephen's suggestion and tap in the password field your input remains unmodified and you are good to go.

But having said all that, this particular use case does seem like it trumps the utility of adding the space, and I agree with the decision to revert the feature.

Needinfo Carrie so she knows that her feature is being reverted.
Flags: needinfo?(cawang)
Comment on attachment 8447840 [details] [review]
Patch V1

Rudy,

The code was originally added as part of bug 927286 in accordance with the spec attached to that bug.

The patch is simple and just removes the space inserting code, which makes it very safe for uplift to 2.0 or even to 1.4.

I wish we had a better fix like some way to detect when input fields are being used for usernames so we could just disable autocorrection in that case.

We could also argue (for 2.1 at least) that we should tweak the autocorrect algorithm so that Stephany->Stephen's is offered as a word suggestion but not as a forced autocorrect. We should perhaps only be autocorrecting when the target word is higher frequency than that.  So if UX really wants to keep the add space on dismiss feature, we could try to tweak the autocorrect parameters to make this less of a problem in practice.
Attachment #8447840 - Flags: review?(dflanagan) → review+
David, thank you. These are great suggestions and helpful.

Yes: When typing in a text message, adding a space is a nice feature. 

I was also hoping that there might be some way to detect when input fields are being used for user names so that we could disable autocorrection in that case. 

Your suggestion of tweaking autocorrect to suggest but not enforce would also be a great fix, and seems like it may be the best course. It seems like determining when fields are and are not being used for usernames and passwords may be difficult to do correctly all or most of the time, but I'm not sure.
Agree with David that we should disable suggesting words in email/ username and account field. ni? Omega to keep tracking this issue since he's the KB UX now. Thanks!
Flags: needinfo?(cawang) → needinfo?(ofeng)
Not adding the space when tapping "x" is a good solution here. I'll update this rule in the UX spec.

It's also good to detect username/email/password field and not to provide autocorrection. I've tried Android and iOS to browse m.facebook.com and they all disable autocorrection in the email field. It uses autocorrect="off" autocapitalize="off" rather than inputmode="verbatim" FYR.
<input autocorrect="off" autocapitalize="off" class="_56bg _55ws _5ruq" name="email" placeholder="Email or Phone" type="text" />
Flags: needinfo?(ofeng)
Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/cfa144ea2400f99db77669c9954bb2cdeaac2526


--
To have a better support on detecting if the input field is for user/account name, we should get Bug 943690 fixed, but it seems it still need more discussion around the standards.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: 2.0 S5 (4july) → 2.0 S6 (18july)
This patch would conflict when uplifted to v2.0, so I'll provide a branch-specific patch for this.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: