AVCC to AnnexB conversion fails

RESOLVED FIXED in mozilla33

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

29 Branch
mozilla33
x86_64
Windows 8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 years ago
See bug 1019291 comment 20 and 21; the AVCC -> AnnexB conversion attached to the stagefright demuxer doesn't work, and we can't play H.264 with the WMF backend for MP4Reader any more.
Can you please attach the file which doesn't play?
(Assignee)

Comment 2

3 years ago
http://yt-dash-mse-test.commondatastorage.googleapis.com/media/car-20120827-85.mp4
(Assignee)

Comment 3

3 years ago
Created attachment 8445601 [details] [diff] [review]
Patch v1

Handle nal length sizes of 1,2,4.

I couldn't figure out how to force avconv/x264 to encode a file with a NAL length size less than 4.  :(
Attachment #8445601 - Flags: review?(ajones)
Wouldn't it be simpler for the demuxer just to write everything out with nalLengthSize of 4?
(Assignee)

Comment 5

3 years ago
Created attachment 8445633 [details] [diff] [review]
Patch v2

Yes, that is simpler.
Attachment #8445601 - Attachment is obsolete: true
Attachment #8445601 - Flags: review?(ajones)
Attachment #8445633 - Flags: review?(ajones)
(Assignee)

Comment 6

3 years ago
Created attachment 8445634 [details] [diff] [review]
Patch v2.1

Whoops, forgot to qref before uploading.
Attachment #8445633 - Attachment is obsolete: true
Attachment #8445633 - Flags: review?(ajones)
Attachment #8445634 - Flags: review?(ajones)
Comment on attachment 8445634 [details] [diff] [review]
Patch v2.1

Try using bzexport in the future. It fails if you have an outstanding qrefresh.
Attachment #8445634 - Flags: review?(ajones) → review+
(Assignee)

Comment 8

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e97ec3feccf8
https://hg.mozilla.org/mozilla-central/rev/e97ec3feccf8
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.