Closed Bug 1029824 Opened 8 years ago Closed 8 years ago

AVCC to AnnexB conversion fails

Categories

(Core :: Audio/Video, defect)

29 Branch
x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: cpearce, Assigned: cpearce)

Details

Attachments

(1 file, 2 obsolete files)

See bug 1019291 comment 20 and 21; the AVCC -> AnnexB conversion attached to the stagefright demuxer doesn't work, and we can't play H.264 with the WMF backend for MP4Reader any more.
Can you please attach the file which doesn't play?
Attached patch Patch v1 (obsolete) — Splinter Review
Handle nal length sizes of 1,2,4.

I couldn't figure out how to force avconv/x264 to encode a file with a NAL length size less than 4.  :(
Attachment #8445601 - Flags: review?(ajones)
Wouldn't it be simpler for the demuxer just to write everything out with nalLengthSize of 4?
Attached patch Patch v2 (obsolete) — Splinter Review
Yes, that is simpler.
Attachment #8445601 - Attachment is obsolete: true
Attachment #8445601 - Flags: review?(ajones)
Attachment #8445633 - Flags: review?(ajones)
Attached patch Patch v2.1Splinter Review
Whoops, forgot to qref before uploading.
Attachment #8445633 - Attachment is obsolete: true
Attachment #8445633 - Flags: review?(ajones)
Attachment #8445634 - Flags: review?(ajones)
Comment on attachment 8445634 [details] [diff] [review]
Patch v2.1

Try using bzexport in the future. It fails if you have an outstanding qrefresh.
Attachment #8445634 - Flags: review?(ajones) → review+
https://hg.mozilla.org/mozilla-central/rev/e97ec3feccf8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.