Closed Bug 1029853 Opened 10 years ago Closed 10 years ago

[Rocketbar][Browser] If the settings page is open for the browser and the rocketbar is used to search, the settings page is seen

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Browser
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 verified)

Status:
VERIFIED FIXED
Milestone:
2.0 S5 (4july)
Project Flags:
blocking-b2g 2.0+
Tracking Flags:
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: nhirata, Assigned: vingtetun)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

bug1029853.patch
1.10 KB, patch
daleharvey
: review+
Details | Diff | Splinter Review
VIDEO0113_Compress.MP4
2.26 MB, video/mp4
Details
1. go to browser 2. open the tab tray 3. select settings 4. hit home 5. tap rocketbar 6. type in news.google.com Expected: news.google.com Actual: the settings page is still open. Note: 1. just in terms of UX, I would have thought that the settings page would close from this. Gaia 9d2f7bd16a8dc0c74c97c5a40d2f0731f3dfff4b Gecko https://hg.mozilla.org/releases/mozilla-aurora/rev/f118b45daada BuildID 20140624000201 Version 32.0a2 ro.build.version.incremental=108 ro.build.date=Tue Jun 10 19:40:40 CST 2014 flame
ni? ux for whether they think that this is a bug or enhancement.
status-b2g-v2.0: --- → affected
Flags: needinfo?(firefoxos-ux-bugzilla)
Bug.
Flags: needinfo?(firefoxos-ux-bugzilla)
But flagging Francis to check since he's Francis.
Flags: needinfo?(fdjabri)
This also happens for the bookmark overlay, edit bookmark, and add to homescreen. This doesn't happen for the share overlay, because the share overlay cancels out when hitting the home button to switch to rocketbar.
Blocks: 1015336
blocking-b2g: --- → 2.0?
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking+]
Whiteboard: [systemsfe]
The activity handler in the browser needs to close the open dialogs.
Component: Gaia::Search → Gaia::Browser
Attached patch bug1029853.patch — — Splinter Review
Assignee: nobody → 21
Attachment #8445798 - Flags: review?(dale)
blocking-b2g: 2.0? → 2.0+
Removing flag for Francis since correct blocking call has been made here already. Thanks Preeti!
Flags: needinfo?(fdjabri)
Target Milestone: --- → 2.0 S5 (4july)
Comment on attachment 8445798 [details] [diff] [review] bug1029853.patch Review of attachment 8445798 [details] [diff] [review]: ----------------------------------------------------------------- Cheers, looks good
Attachment #8445798 - Flags: review?(dale) → review+
pushed in https://github.com/mozilla-b2g/gaia/commit/fc019c1d90aac52cd857b92c622719225bb50757
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attached video VIDEO0113_Compress.MP4 —
This issue has been successfully verified on Flame 2.0: Gaia-Rev 8d1e868864c8a8f1e037685f0656d1da70d08c06 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3 Build-ID 20141202000201 Version 32.0 Device-Name flame FW-Release 4.4.2 This issue has been successfully verified on Flame 2.1: Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22 Build-ID 20141202001201 Version 34.0 Device-Name flame FW-Release 4.4.2
Status: RESOLVED → VERIFIED
status-b2g-v2.0: fixed → verified
status-b2g-v2.1: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: