102987 - Use more secure way of getting current document URL in links toolbar

Status: RESOLVED WONTFIX

(SeaMonkey :: UI Design, defect)

Description

[Gervase Markham [:gerv]]

Back in bug 87428, jst said:

------- Additional Comments From [e-mail] 2001-10-01 08:13 -------
One can also use

  var ifrq = window.QueryInterface(Components.interfaces.nsIInterfaceRequestor);
  var uri = ifrq.getInterface(Components.interfaces.nsIWebNavication).currentURI;

to get at the current URI if you have full XPConnect priveleges. This is not
100% bullet proof either, but it's less likely to be wrong than using location.href

And someone else said we should use this method instead of the current one.

Gerv

Comment 1

[Mike Young]

From what I understand, there was an issue with that method leaking memory that
was never solved. It is instead recommended to use _content.location until there
is a resolution.

That bug was bug 61886.

adding as depends

Comment 2

[HJ]

"It is instead recommended to use _content.location until there
is a resolution."

I would prefer:  getBrowser().webNavigation.currentURI.spec

_content.location itself looks like a security hazard too :)

/HJ

Comment 3

[Gervase Markham [:gerv]]

I'll leave mstoltz to make the final call. He intends to play with the Links
toolbar from a security point of view.

Gerv

Comment 4

[Gervase Markham [:gerv]]

mstoltz: what did you decide about this?

Gerv

Comment 5

[Gervase Markham [:gerv]]

mstoltz: ping?

Gerv

Comment 6

[Gervase Markham [:gerv]]

The links toolbar is dead :-(

Gerv