1029879 - [FMD] Lockscreen keypad is missing when sending a Lost mode notification

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FindMyDevice, defect)

Description

[Tony Chung [:tchung]]

The lockscreen keypad is missing when a Lost mode notification is sent via FMD.  In order for the user to get back to a usable phone, they would need to toggle the power off / on , and then the lockscreen will reappear.  Otherwise they are stuck and nothing on the screen is interactable.

See screenshot
  
Repro:
1) install 2.0 aurora on Flame (20140624000201)

Gaia      9d2f7bd16a8dc0c74c97c5a40d2f0731f3dfff4b
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/f118b45daada
BuildID   20140624000201
Version   32.0a2
ro.build.version.incremental=109

2) sign into FMD on both client and staging server
3) send a lost mode message to the phone.  You'll have to enter in a lockscreen passcode
4) Verify when the Lost mode notification appears, there is no lockscreen keypad that also appears on the screen.

Expected:
- Lockscreen Keypad appears immediately

Actual;
- missing lockscreen keypad.  must toggle power off/on to retrieve it.

Comment 1

[Tony Chung [:tchung]]

Attachment: screenshot

Comment 2

[Guilherme Gonçalves [:ggp]]

Looks like a lockscreen integration issue, and I can reproduce it on the b2g desktop client. Greg, any idea what's happening? I'm still using the 'lockscreen.lock-immediately' setting as usual [1]

1- https://github.com/mozilla-b2g/gaia/blob/master/apps/findmydevice/js/commands.js#L199

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

I think I didn't modify any related code in lockscreen component. May be this is an issue because of visual refresh?

Comment 4

[Erin Lancaster [:elan]]

Triage team consensus is that this does not block. Invoking power is a fairly intuitive step and if the phone is lost enough for the user/owner to incite lost mode, the device will likely be out of power by the time the find it, anyway.

Comment 5

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: 2014-06-26-17-59-00.png

I've just checked and the bug is present in commit dd9e74d196675b0b05170f0ab94a80a36697a551 (the commit before my first lockscreen visual refresh commit, i.e. bug 950884). While this is probably still a lockscreen bug, the visual refresh bug is probably not at blame.


Some STR without FMD server:
1. In Settings, turn on lockscreen & set-up lockscreen passcode.
2. Lock & unlock your phone.
3. In Settings, turn off lockscreen passcode, then turn off lockscreen.
2. Launch Find My Device app in App Manager on Nightly on desktop, go to its console and type either of the following command:
Before (not including) commit 0f4f8eebae26516a2d92af82fbac1dd7315ea171:
Commands.lock.call(Commands, "Message", "0000", function(){});
After (including) commit 0f4f8eebae26516a2d92af82fbac1dd7315ea171:
Commands._commands.lock.call(Commands, "Message", "0000", function(){});

3. See the bug

and "0000" is the passcode to unlock the phone after step 3, obviously.

Comment 6

[Guilherme Gonçalves [:ggp]]

This bug is not a blocker, but seems to be closely related to bug 1030448, which is. Maybe we should reconsider the decision to not block on this one?

John, thank you very much for looking into this. Greg, if we can assume the visual refresh is not causing this bug, can you please have another look at it? Thanks!

Comment 7

[Erin Lancaster [:elan]]

Re-nomming.

Comment 8

[Preeti Raghunath(:Preeti)]

confirmed that this was meant for 2.0?

Comment 9

[Erin Lancaster [:elan]]

Thank you for isolating; good to know this bug is not due to lock screen visual refresh. If this is caused by lockscreen changes of a different kind, is possible to get this and Bug 1030448 assigned to someone for investigation? The more urgent issue is Bug 1030448. We +'d this bug because we have a hunch it's related. Many thanks in advance.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please read bug 1030448 comment 9.

Comment 11

[Erin Lancaster [:elan]]

Not a blocker, we've found STR to repro 1030448 more complex than what was documented and even if it's related to this bug, neither of them block 2.0. Thank you.

Comment 12

[Tony Chung [:tchung]]

This is verified and fix from landing of bug 1030448

Gaia      ca022f811bcbbda0f89086094a9e92bb220fea18
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/376889ab0e02
BuildID   20140714000202
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220