1029927 - non-SPS build fails: layout/style/nsAnimationManager.h:83:20: error: unknown type name 'TimeStamp'

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jan Beich]

+++ This bug was initially created as a clone of Bug #1028036 +++

On SPS platforms GeckoProfiler.h bootlegs |using mozilla::TimeStamp;|.

In file included from gfx/layers/Unified_cpp_gfx_layers2.cpp:184:
In file included from gfx/layers/composite/AsyncCompositionManager.cpp:24:
dist/include/nsAnimationManager.h:83:20: error: unknown type name 'TimeStamp';
      did you mean 'mozilla::TimeStamp'?
                   TimeStamp aRefreshTime,
                   ^~~~~~~~~
                   mozilla::TimeStamp
ipc/ipdl/_ipdlheaders/mozilla/layers/PCompositorParent.h:55:7: note:
      'mozilla::TimeStamp' declared here
class TimeStamp;
      ^
1 error generated.

http://mozillaproject.osuosl.org:8010/builders/runtests/builds/1646/steps/shell/logs/stdio

Comment 1

[Jan Beich]

Attachment: put SPS on the same boat

Comment 2

[Jan Beich]

Attachment: fix

Comment 3

[Jan Beich]

https://tbpl.mozilla.org/?tree=Try&rev=f2b6086d3d98

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 8445597 [details] [diff] [review]
put SPS on the same boat

Review of attachment 8445597 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, please make sure this doesn't break the build with the appropriate try runs.

Comment 5

[Jan Beich]

Comment on attachment 8445597 [details] [diff] [review]
put SPS on the same boat

Moving to a separate bug as the patch doesn't block checkin and needs more testing.

Comment 6

[Jan Beich]

Comment on attachment 8445600 [details] [diff] [review]
fix

To document bootlegging chain...

In file included from gfx/layers/Unified_cpp_gfx_layers2.cpp:28:
In file included from gfx/layers/client/ClientImageLayer.cpp:7:
In file included from gfx/layers/ImageContainer.h:15:
In file included from dist/include/mozilla/ReentrantMonitor.h:13:
In file included from dist/include/GeckoProfiler.h:197:
In file included from dist/include/GeckoProfilerImpl.h:16:
dist/include/GeckoProfilerFunc.h:19:2: error: test
#error test
 ^
1 error generated.

Comment 7

[Jan Beich]

https://tbpl.mozilla.org/?tree=Try&rev=5d96530cbf1a

Comment 8

[Jan Beich]

Green on at least one SPS platform. If any Red appears it'd be bug 1029948 fault.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/150fe5a9f627

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/150fe5a9f627