Closed Bug 1029927 Opened 6 years ago Closed 6 years ago

non-SPS build fails: layout/style/nsAnimationManager.h:83:20: error: unknown type name 'TimeStamp'

Categories

(Core :: CSS Parsing and Computation, defect)

All
FreeBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1028036 +++

On SPS platforms GeckoProfiler.h bootlegs |using mozilla::TimeStamp;|.

In file included from gfx/layers/Unified_cpp_gfx_layers2.cpp:184:
In file included from gfx/layers/composite/AsyncCompositionManager.cpp:24:
dist/include/nsAnimationManager.h:83:20: error: unknown type name 'TimeStamp';
      did you mean 'mozilla::TimeStamp'?
                   TimeStamp aRefreshTime,
                   ^~~~~~~~~
                   mozilla::TimeStamp
ipc/ipdl/_ipdlheaders/mozilla/layers/PCompositorParent.h:55:7: note:
      'mozilla::TimeStamp' declared here
class TimeStamp;
      ^
1 error generated.

http://mozillaproject.osuosl.org:8010/builders/runtests/builds/1646/steps/shell/logs/stdio
Attached patch put SPS on the same boat (obsolete) — Splinter Review
Attachment #8445597 - Flags: review?(birtles)
Attachment #8445597 - Attachment description: fix → put SPS on the same boat
Attachment #8445597 - Attachment filename: fix.diff → unpollute.diff
Attachment #8445597 - Flags: review?(birtles) → review?(bgirard)
Attached patch fixSplinter Review
Attachment #8445600 - Flags: review?(birtles)
Comment on attachment 8445597 [details] [diff] [review]
put SPS on the same boat

Review of attachment 8445597 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, please make sure this doesn't break the build with the appropriate try runs.
Attachment #8445597 - Flags: review?(bgirard) → review+
Attachment #8445600 - Flags: review?(birtles) → review+
Blocks: 1029948
Comment on attachment 8445597 [details] [diff] [review]
put SPS on the same boat

Moving to a separate bug as the patch doesn't block checkin and needs more testing.
Attachment #8445597 - Attachment is obsolete: true
Comment on attachment 8445600 [details] [diff] [review]
fix

To document bootlegging chain...

In file included from gfx/layers/Unified_cpp_gfx_layers2.cpp:28:
In file included from gfx/layers/client/ClientImageLayer.cpp:7:
In file included from gfx/layers/ImageContainer.h:15:
In file included from dist/include/mozilla/ReentrantMonitor.h:13:
In file included from dist/include/GeckoProfiler.h:197:
In file included from dist/include/GeckoProfilerImpl.h:16:
dist/include/GeckoProfilerFunc.h:19:2: error: test
#error test
 ^
1 error generated.
Green on at least one SPS platform. If any Red appears it'd be bug 1029948 fault.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/150fe5a9f627
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.