If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

User cannot input Rupee symbol

RESOLVED FIXED in Firefox OS v1.4

Status

Firefox OS
Gaia::Keyboard
P1
blocker
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: helloarvin, Assigned: tuxboy)

Tracking

unspecified
2.1 S2 (15aug)
x86_64
Linux
Bug Flags:
in-moztrap +

Firefox Tracking Flags

(blocking-b2g:1.4+, b2g-v1.3T affected, b2g-v1.4 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)

Details

(Whiteboard: sprd bug325534, URL)

Attachments

(6 attachments)

(Reporter)

Description

3 years ago
There's no way to input Rupee symbol especially for India Language IME.
(Reporter)

Comment 1

3 years ago
Hi luke,

In my opinion, the best way is to support Rupee symbol in all India-Language-IME(bengali-Avro、bengali-Probhat、hindi、Tamil) so that it's very helpful and friendly to all India native users. Hence, I tried to add Rupee symbol in those four IMEs but the issue occurred on Tamil[1] for there's no its own private symbol panel like hindi[2] etc. Obviously, it's not a sound way to modify the common symbol panel. 

So, I think maybe we can create a private symbol panel for tamil (copy from hindi or ...) rather than using common symbol panel[3]. Then the Rupee issue would be fixed easily.

How do you think?

thanks a lot. 

[1] https://github.com/mozilla-b2g/gaia/blob/v1.3t/keyboard/layouts/ta.js
[2] https://github.com/mozilla-b2g/gaia/blob/v1.3t/keyboard/layouts/hi.js#L91-L110
[3] https://github.com/mozilla-b2g/gaia/blob/v1.3t/apps/keyboard/js/layout.js#L8-L35
Whiteboard: sprd bug325534
(Reporter)

Updated

3 years ago
Flags: needinfo?(lchang)
status-b2g-v1.3T: --- → affected

Comment 2

3 years ago
(In reply to helloarvin from comment #1)
> So, I think maybe we can create a private symbol panel for tamil (copy from
> hindi or ...) rather than using common symbol panel[3]. Then the Rupee issue
> would be fixed easily.

Hi Arvin,

It's totally fine. You can create a private symbol panel for Tamil (just copy that from Hindi). As you said, it doesn't make sense to modify the common symbol panel because it will affect other irrelevant keyboards.

There's no private symbol panel in Tamil just because it wasn't necessary formerly. You can add one now for your own purpose.
Flags: needinfo?(lchang)
let's not add additional scope to Tarako
add to backlog
blocking-b2g: 1.3T? → backlog
(Reporter)

Comment 4

3 years ago
Created attachment 8449307 [details] [diff] [review]
add_Rupee_symbol_for_all_INDIA_IMEs.patch

As far as I know, there are four IMEs of India language in v1.3t and they are: 'Bangla - Avro', 'Bangla - Probhat', 'Hindi' and 'Tamil'.

For the first three IMEs, I just add the Rupee symbol and replace the default currency symbol '$' with Rupee(this might be much more reasonable for local user).

Specially, I replace '@' with Rupee symbol in its "shift" key panel. This is because we've discussed the rationality to place '@', '!' and '?' mark on the panel[1,2]. So, to place the Rupee symbol on the panel would be quite convenient and friendly for local user, and meanwhile the changes could be kept to a minimum.

Please help review my patch, thanks a lot.
 
[1]https://bugzilla.mozilla.org/show_bug.cgi?id=991509#c6
[2]https://bugzilla.mozilla.org/show_bug.cgi?id=991509#c10
Attachment #8449307 - Flags: review?(lchang)

Comment 5

3 years ago
Comment on attachment 8449307 [details] [diff] [review]
add_Rupee_symbol_for_all_INDIA_IMEs.patch

Hi Arvin,

r+ since it looks reasonable. I'd like to know which branch you intend to land this patch? v1.3t or v1.4?
Attachment #8449307 - Flags: review?(lchang) → review+
Flags: needinfo?(arvin.zhang)
(Reporter)

Comment 6

3 years ago
(In reply to Luke Chang [:lchang] from comment #5)
> Comment on attachment 8449307 [details] [diff] [review]
> add_Rupee_symbol_for_all_INDIA_IMEs.patch
> 
> Hi Arvin,
> 
> r+ since it looks reasonable. I'd like to know which branch you intend to
> land this patch? v1.3t or v1.4?

Hi Luke,

First of all, we should land it into the branch v1.3t.

Secondly, I think this is a common issue for all branches including master, because it's a very serious problem for all native Indian user cannot input their own currency symbol Rupee via FFOS.

So, can we land the patch to all branches?

Thank you.
Flags: needinfo?(arvin.zhang) → needinfo?(lchang)

Comment 7

3 years ago
Comment on attachment 8449307 [details] [diff] [review]
add_Rupee_symbol_for_all_INDIA_IMEs.patch

I just noticed that there's no longer '$' sign on Hindi keyboard which means Hindi users have no way to input '$' sign after this patch landed. Is it correct?
Flags: needinfo?(arvin.zhang)
(Reporter)

Comment 8

3 years ago
Hindi user can still input '$' via common symbol panel[1], and Rupee must be the most frequently used currency symbol rather than '$'. So it is sound to place Rupee in hindi keyboard for native user and support to type '$' via common symbol with a little more steps(first click '?१२३' and then click ALT).

How do you think?

[1] https://github.com/mozilla-b2g/gaia/blob/v1.3t/apps/keyboard/js/layout.js#L36-L57
Flags: needinfo?(arvin.zhang)

Comment 9

3 years ago
However, there's no common symbol panel in hindi keyboard. Instead, it uses private one which you just modified its '$' sign.
(Reporter)

Comment 10

3 years ago
Type 'ALT' on the panel I modified '$' sign of hindi keyboard, it will show another symbol panel which is the common panel for all IMEs. Am I right?
Yes, you're right. I just got confused with duplicate '$' signs in the common symbol panel.

I can help to land this patch in master branch first. However, you may need to nominate it for v1.3t? again if you need this patch in v1.3t branch.
Flags: needinfo?(lchang)
(Reporter)

Comment 12

3 years ago
yeah, thank you very much.

I will nominate for both v1.3t and v1.4 later.
Summary: [Tarako] User cannot input Rupee symbol → User cannot input Rupee symbol
Created attachment 8450911 [details] [review]
Pull Request 21379

Waiting for testing process.
Comment on attachment 8450911 [details] [review]
Pull Request 21379

Hi Rudy,

Since this patch will be landed in master branch, could you help to review it? Thanks.
Attachment #8450911 - Flags: review?(rlu)
Comment on attachment 8450911 [details] [review]
Pull Request 21379

I don't understand why we handle bn-Avro and bn-Probhat differently, and please refer to my comment, 
https://github.com/mozilla-b2g/gaia/pull/21379/files#discussion_r14584685

Arvin, Luke, could you help  to take a look at the above questions?
Thanks.
Attachment #8450911 - Flags: review?(rlu)
Flags: needinfo?(arvin.zhang)
(Reporter)

Comment 16

3 years ago
Hi Luke, 

Could you please help explain the question of Rudy on the difference between bn-Avro and bn-Probhat?

As for https://github.com/mozilla-b2g/gaia/pull/21379/files#discussion_r14584685, I just took it for granted that it had been used the same as bn-Avro. I also think we could remove it for it's never been used. How do you think?

Thanks.
Flags: needinfo?(arvin.zhang) → needinfo?(lchang)
Hi Arvin,

I think Rudy means that why you changed the "$" sign into Rupee symbol in the alternateLayout of "bn-Probhat" but remained "৳" symbol in the same position in "bn-Avro"? Do you have any idea about making these symbol panels more consistent between two layouts?
Flags: needinfo?(lchang) → needinfo?(arvin.zhang)
(Reporter)

Comment 18

3 years ago
In the alternateLayout of "bn-Avro", we use "৳" stood for currency symbols so I just add Rupee to the its value-set('৳': '₹ $ € £ ¥').

As for "bn-Probhat", I changed the '$' to Rupee symbol for the latter is the most common currency sign for Hindi user. Due to inertial thinking, I also insert Rupee to the value-set of '৳' and took it for granted that it had been used the same as bn-Avro. In fact, however, it's never been used in "bn-Probhat".

In my opinion, we might replace the '$' sign into "৳" in the alternateLayout of "bn-Probhat" and then what need do is just to add Rupee symbol into its value-set.

Do you think so?

Thanks.
Flags: needinfo?(arvin.zhang) → needinfo?(lchang)
(In reply to helloarvin from comment #18)
> In my opinion, we might replace the '$' sign into "৳" in the alternateLayout
> of "bn-Probhat" and then what need do is just to add Rupee symbol into its
> value-set.
> 
> Do you think so?

I personally prefer this way but I have no idea which is better to native users.

Rudy, could you confirm that? Thanks.
Flags: needinfo?(lchang) → needinfo?(rlu)
Let's ni the original author about this, since I know nothing about Bangla.

Aniruddha,

could you help take a look at comment 18?
Thank you.
Flags: needinfo?(rlu) → needinfo?(aniruddha)
(Reporter)

Comment 21

3 years ago
Hi aniruddha,

Any update here, thanks?
(Assignee)

Comment 22

3 years ago
I am looking into this tonight, was on vacation for a few days.
Flags: needinfo?(aniruddha)
(Reporter)

Comment 23

3 years ago
(In reply to Aniruddha Adhikary from comment #22)
> I am looking into this tonight, was on vacation for a few days.

Any fresh developments?

Please feel free to tell me if anything needs to be improved.
Thanks.
(Reporter)

Comment 24

3 years ago
Dear Aniruddha Adhikary,

Any fresh developments?
Please feel free to tell me if anything needs to be improved.

Thanks a lot.
Flags: needinfo?(aniruddha)
(Assignee)

Comment 25

3 years ago
Fixed. https://github.com/mozilla-b2g/gaia/pull/22533
Flags: needinfo?(aniruddha)
(Assignee)

Comment 26

3 years ago
Created attachment 8467962 [details] [review]
adds rupee sign
(Reporter)

Comment 27

3 years ago
Dear Aniruddha Adhikary,

BTW, do we need add rupee sign for another two languages 'hi' and 'ta'?

Thanks.
Flags: needinfo?(aniruddha)
(Assignee)

Comment 28

3 years ago
Hi hellarvin,

Yes, we needed to add rupee sign for 'hi', and I just updated my commit and added it. But, I don't see a key mapped to '$' or any other currency symbol in the 'ta' layout. So, I avoided 'ta'.

And bn-Avro and bn-Probhat are common layouts for Bangla, both originated in Bangladesh and are used in both West Bengal (India) and Bangladesh itself. There is no such case of Probhat being a layout for India and Avro being a layout for Bangladesh!
Flags: needinfo?(aniruddha)
(Reporter)

Comment 29

3 years ago
Thank you very much.

As for 'ta', please refer to the comment 4 and feel free to tell me your opinions.
--------------------------------------------------------------------
Specially, I replace '@' with Rupee symbol in its "shift" key panel. This is because we've discussed the rationality to place '@', '!' and '?' mark on the panel[1,2]. So, to place the Rupee symbol on the panel would be quite convenient and friendly for local user, and meanwhile the changes could be kept to a minimum.

[1]https://bugzilla.mozilla.org/show_bug.cgi?id=991509#c6
[2]https://bugzilla.mozilla.org/show_bug.cgi?id=991509#c10
Flags: needinfo?(aniruddha)
(Assignee)

Comment 30

3 years ago
Just added the rupee symbol in place of the shifted layout's '@' of the 'ta' keyboard.
Flags: needinfo?(aniruddha)
(Reporter)

Comment 31

3 years ago
Yeah, I think it's good enough.

Hi Rudy and Luke,

Could you please help review the Aniruddha's PR on adding Rupee symbol?
https://github.com/mozilla-b2g/gaia/pull/22533/files

Thank you all.
Flags: needinfo?(rlu)
Flags: needinfo?(lchang)
Comment on attachment 8467962 [details] [review]
adds rupee sign

I'll take a look at this patch.
Thanks.
Attachment #8467962 - Flags: review?(rlu)
Flags: needinfo?(rlu)
Flags: needinfo?(lchang)
Comment on attachment 8467962 [details] [review]
adds rupee sign

These changes look good to me, r+.
I think you guys are native to these languages so I don't have to find other native speakers to take a look.
Attachment #8467962 - Flags: review?(rlu) → review+
Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/37b515006398f8b1394c78f5001816ff2e92207b
Assignee: nobody → aniruddha
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-b2g-v2.1: --- → fixed
Resolution: --- → FIXED
(Reporter)

Comment 35

3 years ago
[Blocking Requested - why for this release]: This is a common issue for each branch including v1.4.

Rudy, please help land the patch into the branch v1.4, thank you.
blocking-b2g: backlog → 1.4?
Flags: needinfo?(rlu)
This can only land to v1.4 if it got +'ed, and this would need to go through the triage for the decision.
Flags: needinfo?(rlu)
triage - 1.4+ as required for target launch candidate
blocking-b2g: 1.4? → 1.4+
This will need rebasing for v1.4 uplift. Also, please nominate this for v2.0 uplift if it is needed there as well.
status-b2g-v1.4: --- → affected
status-b2g-v2.0: --- → ?
Flags: needinfo?(aniruddha)
Target Milestone: --- → 2.1 S2 (15aug)
Keywords: branch-patch-needed
(Assignee)

Comment 39

3 years ago
Created attachment 8470189 [details] [review]
rupee symbol fix for v1.4
(Assignee)

Comment 40

3 years ago
Created attachment 8470191 [details] [review]
rupee symbol fix for v2.0

rupee symbol fix for v2.0
Flags: needinfo?(aniruddha)
v2.0: https://github.com/mozilla-b2g/gaia/commit/195df2d81cd5fff0aeffb81924cf5a75d59676ff
v1.4: https://github.com/mozilla-b2g/gaia/commit/4a662f6dd831cf6194d7ad3501b1d56ea2964a20

Thanks!
status-b2g-v1.4: affected → fixed
status-b2g-v2.0: ? → fixed
Keywords: branch-patch-needed

Updated

3 years ago
Flags: in-moztrap?(smiko)
A test case needs to be created to cover this issue
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Flags: in-moztrap?(smiko)
Flags: in-moztrap?(dharris)
Test case added in moztrap:

https://moztrap.mozilla.org/manage/case/14337/
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Flags: in-moztrap?(dharris)
Flags: in-moztrap+
Created attachment 8476456 [details] [review]
Pull Request 23126 for v1.4 (hi & ta)

According to Bug 987496 comment 42, we just decided to uplift Hindi and Tamil input methods to v1.4 branch few days ago.

However, this bug has already been uplifted to v1.4 before we uplift those input methods so there is no Hindi and Tamil parts in the uplifted patch. For this reason, I'd like to uplift this patch to v1.4 once more here.
Uplifted to v1.4 branch.
https://github.com/mozilla-b2g/gaia/commit/96a35ee90b46aca87623cc85f28ca44b4fd2c909
You need to log in before you can comment on or make changes to this bug.