Closed
Bug 1029948
Opened 10 years ago
Closed 10 years ago
Avoid global scope pollution of TimeStamp/TimeDuration via GeckoProfiler.h on SPS platforms
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: jbeich, Assigned: jbeich)
References
Details
Attachments
(1 file)
|
10.29 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
To avoid breaking non-SPS platforms such as Linux non-x86/x86_64, various BSDs and Solaris every time mozilla/TimeStamp.h is used with sometimes implicitly include GeckoProfiler.h.
https://tbpl.mozilla.org/?tree=Try&rev=5d96530cbf1a
Attachment #8445850 -
Flags: review?(bgirard)
Let's also confirm SPS now fails without bug 1029927 - the desired effect. https://tbpl.mozilla.org/?tree=Try&rev=eb88d7dffb64
|
||
Updated•10 years ago
|
Attachment #8445850 -
Flags: review?(bgirard) → review+
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
sorry had to backout for bustage like https://tbpl.mozilla.org/php/getParsedLog.php?id=42516908&tree=Fx-Team
Whiteboard: [fixed-in-fx-team]
That's known. Please check-in together with bug 1029927.
Keywords: checkin-needed
|
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3db5a84c364
Keywords: checkin-needed
|
||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c3db5a84c364
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•