Avoid global scope pollution of TimeStamp/TimeDuration via GeckoProfiler.h on SPS platforms

RESOLVED FIXED in Firefox 33

Status

()

Firefox
Developer Tools: Performance Tools (Profiler/Timeline)
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Jan Beich, Assigned: Jan Beich)

Tracking

Trunk
Firefox 33
All
FreeBSD
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
To avoid breaking non-SPS platforms such as Linux non-x86/x86_64, various BSDs and Solaris every time mozilla/TimeStamp.h is used with sometimes implicitly include GeckoProfiler.h.
(Assignee)

Updated

4 years ago
Depends on: 1029927, 1028036
(Assignee)

Comment 1

4 years ago
Created attachment 8445850 [details] [diff] [review]
put SPS on the same boat, v2

https://tbpl.mozilla.org/?tree=Try&rev=5d96530cbf1a
Attachment #8445850 - Flags: review?(bgirard)
(Assignee)

Comment 2

4 years ago
Let's also confirm SPS now fails without bug 1029927 - the desired effect.
https://tbpl.mozilla.org/?tree=Try&rev=eb88d7dffb64

Updated

4 years ago
Attachment #8445850 - Flags: review?(bgirard) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/9554986d30fc
Assignee: nobody → jbeich
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
sorry had to backout for bustage like https://tbpl.mozilla.org/php/getParsedLog.php?id=42516908&tree=Fx-Team
Whiteboard: [fixed-in-fx-team]
(Assignee)

Comment 5

4 years ago
That's known. Please check-in together with bug 1029927.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c3db5a84c364
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
You need to log in before you can comment on or make changes to this bug.