Closed Bug 1029948 Opened 6 years ago Closed 6 years ago

Avoid global scope pollution of TimeStamp/TimeDuration via GeckoProfiler.h on SPS platforms

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

All
FreeBSD
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file)

To avoid breaking non-SPS platforms such as Linux non-x86/x86_64, various BSDs and Solaris every time mozilla/TimeStamp.h is used with sometimes implicitly include GeckoProfiler.h.
Depends on: 1029927, 1028036
Let's also confirm SPS now fails without bug 1029927 - the desired effect.
https://tbpl.mozilla.org/?tree=Try&rev=eb88d7dffb64
Attachment #8445850 - Flags: review?(bgirard) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/9554986d30fc
Assignee: nobody → jbeich
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
sorry had to backout for bustage like https://tbpl.mozilla.org/php/getParsedLog.php?id=42516908&tree=Fx-Team
Whiteboard: [fixed-in-fx-team]
That's known. Please check-in together with bug 1029927.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c3db5a84c364
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.