1029953 - wget version in MozillaBuild doesn't like https://ftp.m.o

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Martin Thomson [:mt:]]

This took a while to diagnose, but the problem is a combination of factors: an ancient version of wget and an out of date CA bundle.  Both need updating.

I was able to build a new ca-bundle.crt file using the script from CURL: https://github.com/bagder/curl/blob/master/lib/mk-ca-bundle.vbs

Then I was able to download a recent wget binary from http://eternallybored.org/misc/wget/

I'm reluctant to upload a massive binary patch with all the updated files, but will do so if that makes someone's life any easier.

I'd really like to have us use https URLs for downloading files more often, but that can't happen until our tools support it properly.  On the plus side, this is easy to fix.

Comment 1

[Ed Morley [:emorley]]

See also bug 566234.

Comment 2

[(not currently active) Ted Mielczarek]

So the nice thing is that updating these files is a simple matter of checking in new files in the mozilla-build repo:
http://hg.mozilla.org/mozilla-build/file/efb71fed5c28/ca-bundle.crt
http://hg.mozilla.org/mozilla-build/file/efb71fed5c28/wget-1.10.2b.zip
http://hg.mozilla.org/mozilla-build/file/efb71fed5c28/wget-1.10.2s.zip (I believe this is just the source bundle.)
and tweaking the install script if the zip file name changes:
http://hg.mozilla.org/mozilla-build/file/efb71fed5c28/packageit.sh#l94

The downside is that you need to get a new MozillaBuild released to take advantage of it. You might be able to convince RyanVM to do that, though.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Definitely able to be convinced :)

Martin, if you want to submit a patch with just the non-binary changes, I'd be happy to take a look.

Comment 4

[Martin Thomson [:mt:]]

Happy to do so.  I'll include instructions for acquiring the binary parts at the same time.

Comment 5

[Martin Thomson [:mt:]]

Attachment: bug1029953.patch

My windows machine lives elsewhere, so I haven't tested this, but the changes are trivial.

I have suppressed the binary changes.  You'll need to remove the existing wget zips and then:

http://eternallybored.org/misc/wget/wget-1.15-win32.zip 
  >> wget-1.15b.zip
http://eternallybored.org/misc/wget/src/wget-1.15.tar.xz
  >> wget-1.15s.tar.xz

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8446006 [details] [diff] [review]
bug1029953.patch

Review of attachment 8446006 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks. I can land this for you if you want.

Comment 7

[Martin Thomson [:mt:]]

Please do.  And thanks.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/mozilla-build/rev/ced55786b25e