Observers should use MOZ_UTF16 to compare someData

RESOLVED FIXED in mozilla33

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

unspecified
mozilla33
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Some observers use the following to check aData.

   if (!strcmp(NS_ConvertUTF16toUTF8(aData).get(), "full")) {

Now, we can use MOZ_UTF16, so we should use NS_strcmp(xxxx, MOZ_UTF16(yyy)) instead.
(Assignee)

Comment 1

4 years ago
Created attachment 8445686 [details] [diff] [review]
Replace with using MOZ_UTF16
(Assignee)

Updated

4 years ago
Attachment #8445686 - Flags: review?(nfroyd)
Attachment #8445686 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 2

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2f064eaa41a
Target Milestone: --- → mozilla33
https://hg.mozilla.org/mozilla-central/rev/a2f064eaa41a
Assignee: nobody → m_kato
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.