Closed Bug 1029981 Opened 6 years ago Closed 6 years ago

Observers should use MOZ_UTF16 to compare someData

Categories

(Core :: General, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

Some observers use the following to check aData.

   if (!strcmp(NS_ConvertUTF16toUTF8(aData).get(), "full")) {

Now, we can use MOZ_UTF16, so we should use NS_strcmp(xxxx, MOZ_UTF16(yyy)) instead.
Attachment #8445686 - Flags: review?(nfroyd)
Attachment #8445686 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/a2f064eaa41a
Assignee: nobody → m_kato
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.