Closed Bug 1029992 Opened 6 years ago Closed 6 years ago

Make mozilla::pkix::der::AlgorithmIdentifier less error-prone to use and more consistent with other mozilla::pkix::der functions

Categories

(Core :: Security: PSM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: briansmith, Assigned: briansmith)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1029364 +++

AlgorithmIdentifier expects to be called via a call to Nested() that unwraps the and checks the tag and length. This is inconsistent with OptionalVersion, OptionalExtensions, GeneralizedTime, soon TimeChoice, and other functions for decoding universal types. This patch changes AlgorithmIdentifier so that the calling code is less repetitive and less error-prone.
Attachment #8445699 - Flags: review?(cviecco)
Attachment #8445699 - Flags: review?(cviecco) → review+
https://hg.mozilla.org/mozilla-central/rev/93bc682527b4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.