1030006 - New Webmaker Pages are missing Google Analytics tags

Status: RESOLVED FIXED

(Webmaker Graveyard :: Metrics, defect)

Description

[Adam Lofting (:adamlofting)]

And therefore GA is missing data.

On the plus side, this might mean that conversion rate hasn't fallen off a cliff - but we won't know for sure until we get the tags back on prod.

Can we add our GA tags into the new homepage, and any other new pages like the resources pages that shipped to prod on 16 June. The way this currently works on https://webmaker.org/tools is correct.

(I'm not sure how we want to whiteboard this as it would be good to fix ahead of the next release if that doesn't cause major headaches).

Comment 1

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/webmaker.org/pull/839

Comment 2

[Chris DeCairos (:cade)]

Comment on attachment 8448074 [details] [review]
https://github.com/mozilla/webmaker.org/pull/839

This will add GA to angular pages, but is there more to be done for this bug?

Comment 3

[Brett Gaylor [:brett]]

nope, assuming aki gives that an R+, ship it!

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/bc1d29022a091efdc19d2124c762c8ed48cbb80b
Bug 1030006 - Add GA script to index-angular

Comment 5

[Adam Lofting (:adamlofting)]

Comment on attachment 8448074 [details] [review]
https://github.com/mozilla/webmaker.org/pull/839

A belated R+

And, thanks!

Comment 6

[Adam Lofting (:adamlofting)]

Data is coming into staging now, I'll leave this ticket open until we're on prod.

Comment 7

[Chris DeCairos (:cade)]

Pushing to prod: https://jenkins.mofoprod.net/view/PROD/job/PRODPUSH-webmakerorg/110/

Comment 8

[Chris DeCairos (:cade)]

Via IRC:

> <adamlofting> yes, tracking has returned :)