103003 - msg db leaking dbfolderinfo table and row

Status: VERIFIED FIXED

(MailNews Core :: Database, defect)

Description

[David :Bienvenu]

there's a mork leak that has a bunch of mork stuff and then some of the
following calls in the stack:

orkinStore::GetTableKind()
nsresult nsDBFolderInfo::InitFromExistingDB()
fix coming up.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

Comment 2

[David :Bienvenu]

the problem was that in the destructor for nsDBFolderInfo, we were skipping the
release of the table and row because m_mdb was null, and that's because we're
nulling it out in the code that's in the patch. Since this is just a pointer,
not a comptr, the patch works fine.

nsDBFolderInfo::~nsDBFolderInfo()
{
  if (gReleaseObserver) 
  {
    NS_IF_RELEASE(gFolderCharsetObserver);
  }
	if (m_mdb)
	{
		if (m_mdbTable)
			m_mdbTable->CutStrongRef(m_mdb->GetEnv());
		if (m_mdbRow)
			m_mdbRow->CutStrongRef(m_mdb->GetEnv());
		// nsMsgDatabase strictly owns nsDBFolderInfo, so don't ref-count db.
//
	m_mdb->Release();
	}
}

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 51958 [details] [diff] [review]
proposed fix

sr=sspitzer

Comment 4

[Navin Gupta]

r=naving

Comment 5

[David :Bienvenu]

fix checked in.

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

I didn't see this with the following operations:

* loading a folder
* dragging a message into a folder
* deleting a message

Verified FIXED using Win2K and Purify (latest opt build with symbols).