If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Disable OMTC on windows on Aurora

RESOLVED FIXED in Firefox 32

Status

()

Core
Graphics
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: bas, Assigned: bas)

Tracking

unspecified
mozilla32
x86_64
Windows 8.1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox32 fixed, firefox33 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Created attachment 8445874 [details] [diff] [review]
Switch off OMTC on windows.

There's still some issues with OMTC on windows that are being worked on. Fast WebGL and some other fixes are only on trunk and we shouldn't be uplifting them. For now we're just going for the low-risk solution and switch off OMTC on aurora, the weeks it's been on there have already given us a lot of useful information.
Attachment #8445874 - Flags: review?(milan)
Attachment #8445874 - Flags: approval-mozilla-aurora?
Comment on attachment 8445874 [details] [diff] [review]
Switch off OMTC on windows.

Review of attachment 8445874 [details] [diff] [review]:
-----------------------------------------------------------------

Let's make sure this is Aurora only patch.  We want to keep running with OMTC on the trunk (I know Bas knows, just saying it for clarity.)
Attachment #8445874 - Flags: review?(milan) → review+

Comment 2

3 years ago
Comment on attachment 8445874 [details] [diff] [review]
Switch off OMTC on windows.

Review of attachment 8445874 [details] [diff] [review]:
-----------------------------------------------------------------

Why not just delete this whole ifdef block? Both prefs are already set accordingly before this one...
Attachment #8445874 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 3

3 years ago
I was just trying to minimize churn in the patch :). I don't care either way.
Low churn is good.  Thanks.
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/c538efe3b0bf
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
status-firefox32: --- → fixed
Target Milestone: --- → mozilla32
Depends on: 1032831
Comment on attachment 8445874 [details] [diff] [review]
Switch off OMTC on windows.

[Triage Comment]
We decided to disable OMTC for 33 under Windows for beta7 to have an idea of the crash rate. This should land for beta 7.
Attachment #8445874 - Flags: approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/f631df57b34c
status-firefox33: --- → fixed
Created attachment 8493975 [details] [diff] [review]
Release the DrawTarget to drop the surface ref

Approval Request Comment
[Feature/regressing bug #]: Bug 1030147
[User impact if declined]: Debug build aborts.
[Describe test coverage new/current, TBPL]:
[Risks and why]: Super low risk, hope it works :)
[String/UUID change made/needed]: None
Attachment #8493975 - Flags: review?(bas)
Attachment #8493975 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/releases/mozilla-beta/rev/280407351f1b
Comment on attachment 8493975 [details] [diff] [review]
Release the DrawTarget to drop the surface ref

I discussed this patch with Matt and Bas. Approving for Beta to try and get back to green with OMTC disabled.
Attachment #8493975 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Reftest failures :(
https://tbpl.mozilla.org/php/getParsedLog.php?id=48726147&tree=Mozilla-Beta
Flags: needinfo?(bas)
(Assignee)

Updated

3 years ago
Attachment #8493975 - Flags: review?(bas) → review+

Updated

3 years ago
Depends on: 1074024
I assume we haven't released anything with OMTC?  Here are the talos performance difference with omtc:
http://alertmanager.allizom.org:8080/alerts.html?rev=f631df57b34c&table=1

Comment 13

3 years ago
(In reply to Joel Maher (:jmaher) from comment #12)
> I assume we haven't released anything with OMTC?

Yes. After bug 1074045 lands, 33 will be the first release with OMTC on Windows.
(Assignee)

Updated

3 years ago
Flags: needinfo?(bas)
You need to log in before you can comment on or make changes to this bug.