Closed Bug 1030200 Opened 10 years ago Closed 10 years ago

[vertical] Smart Collection name is not localized in offline-webresults error message

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S5 (4july)
blocking-b2g 2.0+
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: theo, Assigned: kgrandon)

References

Details

(Whiteboard: [p=2],[systemsfe])

Attachments

(3 files)

Attached image Italian, Flame master
The Smart Collection name is not localized in the offline error message displayed to the user.

STR:
1. switch language to Italian
2. Switch off Wi-Fi and data
3. Open Intrattenimento Smart Collection

Actual result:
Connettersi a Internet per scoprire le app in Showbiz

Expected:
Connettersi a Internet per scoprire le app in Intrattenimento


Added qawanted to test on 2.0

Tested on Flame 2.1:
Gaia      2944695a89c3281d49dbe5ff9c0cd26c8318e2ba
Gecko     https://hg.mozilla.org/mozilla-central/rev/215b93e07e1d
BuildID   20140624160202
Version   33.0a1
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [p=2],[systemsfe]
Target Milestone: --- → 2.0 S5 (4july)
This is a naming issue, reproducible in the English version too. I guess bug 1028455 is back.
blocking-b2g: --- → 2.0?
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking+]
Keywords: qawanted
See Also: → 1028455
Attached file Github pull request
Blocks: 1015336
Attachment #8445972 - Flags: review?(ran)
Attachment #8445972 - Flags: review?(jlal)
Comment on attachment 8445972 [details] [review]
Github pull request

looks good...
Attachment #8445972 - Flags: review?(jlal) → review+
Comment on attachment 8445972 [details] [review]
Github pull request

Ran - feel free to leave any comments if you have them. Thanks!
Attachment #8445972 - Flags: review?(ran)
Landed: https://github.com/mozilla-b2g/gaia/commit/77ca53a077d3310b1b4aac152ca39e0acd92d5a6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8445972 [details] [review]
Github pull request

This is needed for the vertical homescreen.
Attachment #8445972 - Flags: approval-gaia-v2.0?(bbajaj)
blocking-b2g: 2.0? → 2.0+
Keywords: verifyme
Attachment #8445972 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Verified fixed with Gaia master cb2d65a8adc929756d3cda4881c36e67c3fae666

Thanks a lot Kevin, works perfectly!
Status: RESOLVED → VERIFIED
Keywords: verifyme
Lgtm apart for one line I'd like to discuss. Commented on GH.
Attached video VIDEO0085_Compress.MP4
This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2


This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: