Closed Bug 1030313 Opened 11 years ago Closed 11 years ago

Port existing filters to new plugin API

Categories

(Webtools Graveyard :: DXR, defect)

Product:
Webtools Graveyard
Component:
DXR
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: erik, Unassigned)

References

Details

Move the existing core filters to the clang plugin, and rewrite them against the new plugin API, so they can consume what the ported clang indexer emits.
Some of the filters that aren't specifically clangy will move to the core plugin instead.
Commits pushed to es at https://github.com/mozilla/dxr https://github.com/mozilla/dxr/commit/608f4ceda17fecb7f1f9155da22617afdf4ff6bc Get PathFilter working by hooking it up to the JS regex rewriter. Refs bug 1030313. You should now be able to fire up test_basic and run path queries, complete with globs. * All of test_basic passes except test_structural_and, which awaits a working `function:` filter. * We introduce a new exception BadQuery, which filters can use to complain about user errors that keep the query from running. In a later commit, we'll catch this and display it instead of 500ing. https://github.com/mozilla/dxr/commit/93d8b96a16cfe66cbacdc09d69fef7cfcd5c7cca Get the path filter working. Close #329. Ref bug 1030313.
Commit pushed to es at https://github.com/mozilla/dxr https://github.com/mozilla/dxr/commit/97ae7c5c6f42dd1fe43e3361731f216973c6fe98 Add RegexFilter. Ref bug 1030313. All of test_strings passes except test_empty_quotes. * Percolate is_case_sensitive kwarg through more of the test routines so we could use it in SingleFileTestCase.found_line_eq(). * Index the content field of lines so the script filter can pull it to run the regex against.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.