1030352 - Delete/undo-delete phone number button in edit dialog does not have an accessibility label.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Eitan Isaacson [:eeejay]]

Also, this markup shows two nested buttons, this is wrong:

<button class="fillflow-row-action" id="img-delete-button">
  <span class="icon-delete" role="button"></span>
</button>

Comment 1

[Eitan Isaacson [:eeejay]]

Re-aligning priorities with 2.1 accessibility goals.

Comment 2

[Manuel Casas Barrado [:mancas]]

Attachment: Localizing the aria-label attribute in the button

I've added the aria-label attribute to this button in order to make it accessible to the Screen reader

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 8453683 [details] [review]
Localizing the aria-label attribute in the button

redirecting to a contact peer

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8453683 [details] [review]
Localizing the aria-label attribute in the button

Redirecting to Sergi, I'm a bit overloaded and don't want this patch to be in my queue forever.

Thanks!

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi, I added a couple of comments in the PR. Also, the markup still seems to be semantically wrong as mentioned in comment 0.

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Also, please use a11y-review flag for all bugs that have a keyword 'access'.

Comment 7

[Manuel Casas Barrado [:mancas]]

(In reply to Yura Zenevich [:yzen] from comment #6)
> Also, please use a11y-review flag for all bugs that have a keyword 'access'.

Hi Yura, please take a look at the PR. I've made some changes. Regarding the comment0, I think it's another different bug and we need more info from UX to resolve it, because if we change the markup, I'm sure the CSS will break.

Comment 8

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Comment on attachment 8453683 [details] [review]
Localizing the aria-label attribute in the button

Looks good, thanks!

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

Sorry had to remove the a11y-review+: could you change the string 'Remove field' to just 'Remove', thanks!

Comment 10

[Eitan Isaacson [:eeejay]]

In addition to Yura's feedback, I think the button should keep the same label of "Remove", and be a toggle button. That will be much more intuitive than a button that changes its label. I put details in the PR about how that is done.

Comment 11

[Manuel Casas Barrado [:mancas]]

(In reply to Yura Zenevich [:yzen] from comment #9)
> Sorry had to remove the a11y-review+: could you change the string 'Remove
> field' to just 'Remove', thanks!

I've changed the string. Please take a look. Thanks

Comment 12

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Manuel Casas Barrado [:mancas] from comment #11)
> (In reply to Yura Zenevich [:yzen] from comment #9)
> > Sorry had to remove the a11y-review+: could you change the string 'Remove
> > field' to just 'Remove', thanks!
> 
> I've changed the string. Please take a look. Thanks

One more comment in the PR. Thanks.

Comment 13

[Manuel Casas Barrado [:mancas]]

(In reply to Yura Zenevich [:yzen] from comment #12)
> (In reply to Manuel Casas Barrado [:mancas] from comment #11)
> > (In reply to Yura Zenevich [:yzen] from comment #9)
> > > Sorry had to remove the a11y-review+: could you change the string 'Remove
> > > field' to just 'Remove', thanks!
> > 
> > I've changed the string. Please take a look. Thanks
> 
> One more comment in the PR. Thanks.

Done! Thanks

Comment 14

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8453683 [details] [review]
Localizing the aria-label attribute in the button

Thanks! a11y-review=me with just 2 nits (commented on Github PR).

Comment 15

[Manuel Casas Barrado [:mancas]]

(In reply to Yura Zenevich [:yzen] from comment #14)
> Comment on attachment 8453683 [details] [review]
> Localizing the aria-label attribute in the button
> 
> Thanks! a11y-review=me with just 2 nits (commented on Github PR).

Everything done! Let me know if there is something wrong

Thanks

Comment 16

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8453683 [details] [review]
Localizing the aria-label attribute in the button

Thanks Manuel, all looks and works great!

Comment 17

[Manuel Casas Barrado [:mancas]]

master: 9dd4bf0ad0b0397ef9e3664fa52d00bde7d46d1d