1030428 - Log parsing regex is missing failures compared to TBPL

Status: RESOLVED DUPLICATE of bug 1023868

(Tree Management :: Treeherder, defect, P1)

Description

[David Burns :automatedtester]

Attachment: treeherder-missing.jpg

Comment 1

[David Burns :automatedtester]

Attachment: tbpl text there.jpg

how TBPL renders the same text

Comment 2

[David Burns :automatedtester]

the extra data shown makes it simple to star when there are multiple people looking at the trees

Comment 3

[Ed Morley [:emorley]]

The TBPL failure excerpt only shows lines that match the regex, rather than the N lines leading up to it, the issue in the screenshot is actually due to two problems:
1) The log line order is inverted in treeherder (we're showing new-to-old rather than old-to-new).
2) The treeherder regex isn't quite complete (albeit easily fixed :-)).

I'll make this about #2 and file another for #1, since I raised this at a treeherder meeting a few weeks ago, must have not made it to an etherpad, since we talked about so many things during the meeting.

Comment 4

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley UTC+0] from comment #3)
> 1) The log line order is inverted in treeherder (we're showing new-to-old
> rather than old-to-new).

Bug 1030619

Comment 5

[Ed Morley [:emorley]]

Actually, this might just turn out to be bug 1030620 (the regex do need a bit of work, but I don't think it was them in this case)

Comment 6

[Cameron Dawson [:camd]]

We have PROCESS-CRASH as a regex to be found, so I'll double-check that we have that covered in a unit test, so it shows in the log artifact.

Comment 7

[Cameron Dawson [:camd]]

Hmm, I see other jobs that DO get the PROCESS-CRASH error line to show.  And we have specific unit tests for this error case which pass.  I have a suspicion it may be caused by bug 1023868.  Can't confirm that yet, but I'm going to search for another case of this...

Comment 8

[Cameron Dawson [:camd]]

We are picking up PROCESS-CRASH failure lines as seen here:
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=87011&repo=mozilla-central

It is my belief that we missed this because we were missing >1hr steps.  So I'm going to close this as a dup now.  Please reopen if you see it.