1030434 - Add a proper description for the call screen dialog.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

When the call screen dialog is enabled we should announce some helpful description for it, such as the type of the activity (incoming,etc).

Comment 1

[Eitan Isaacson [:eeejay]]

Re-aligning priorities with 2.1 accessibility goals.

Comment 2

[Anup Kumar [:reznord]]

Hi,

I am interested in working on this bug. So, can you please assign it to me?

Thanks in advance,

Regards,
Anup

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Anup Kumar from comment #2)
> Hi,
> 
> I am interested in working on this bug. So, can you please assign it to me?
> 
> Thanks in advance,
> 
> Regards,
> Anup

Hi Kumar, unfortunately this bug requires an actual device to test with. Let me know if you have it, then I ll assign the bug to you, if not I can suggest another good bug.

Comment 4

[Anup Kumar [:reznord]]

> Hi Kumar, unfortunately this bug requires an actual device to test with. Let
> me know if you have it, then I ll assign the bug to you, if not I can
> suggest another good bug.

Hi,

Unfortunately I don't have a device with me. So, as you said I can't work on this bug right now. Anyway thanks for the concern

Comment 5

[Anup Kumar [:reznord]]

Can't I work using an emulator for this bug?

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Anup Kumar from comment #5)
> Can't I work using an emulator for this bug?

I doubt there's a way to enable the callscreen without making the actual call. Unless there is a way..

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Github pull request.

Comment 8

[Anthony Ricaud (:rik)]

Comment on attachment 8469403 [details] [review]
Github pull request.

I'm relying on your expertise to see if that's the proper thing to do.

Only leaving a feedback+ since this needs new tests in https://github.com/mozilla-b2g/gaia/blob/fbcb01fe39cc2eed7b2860f05908521e4936a70a/apps/callscreen/test/unit/handled_call_test.js#L509-L540. Let me know if you can't write them and we'll take care of it.

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8469403 [details] [review]
Github pull request.

Updated the pull request with extra assertions for new attributes.

Comment 10

[Anthony Ricaud (:rik)]

Comment on attachment 8469403 [details] [review]
Github pull request.

Very good, thanks!

Comment 11

[Yura Zenevich [:yzen] (please use "needinfo")]

https://github.com/mozilla-b2g/gaia/commit/6fd2a1ab99b7d4790c5faa268efe56bdf12f5758