1030440 - [Vertical Homescreen] Optimize default icon configuration

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Jacqueline Savory [:jsavory] UX]

Attachment: Icon_Layout.png

The default icon configuration could be improved by organizing the icon layout into certain groups and including more critical apps at the top of the screen. 

I've attached a proposal for a app icon layout that I think works a bit better than the current version.

Comment 2

[Jason Smith [:jsmith]]

Good idea to do, but we'll ship even if this isn't finished.

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Github pull request

This patch should fix the positioning of icons, though the collections are not respecting the default layout. I am investigating.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8448958 [details] [review]
Github pull request

Hey Cristian - 

Would you be able to review this first part of the placement work? There is more work to ensure collections are properly placed, and I'm going to open a new bug for that, as it seems fairly complex.

Comment 5

[Kevin Grandon :kgrandon]

Hmm, for 2.0 phones it seems people don't need bug 1029655 after flashing/updating, so I don't think it's needed. I think our default engineering build might just be wrong though.

Comment 6

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8448958 [details] [review]
Github pull request

LGTM

Comment 7

[Kevin Grandon :kgrandon]

Master: https://github.com/mozilla-b2g/gaia/commit/0d6f755c282de82a27000c2eb2f38c4746c91e96

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8448958 [details] [review]
Github pull request

This is a nice low-risk patch that makes the default icon layout much nicer for users. We would like to uplift for the vertical homescreen.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/a73999afdf458337c68f4f32b54b7fcbc6ec0b0d

Comment 10

[Kevin Grandon :kgrandon]

What is going on with the dependency fiddling?

Comment 11

[krupa raj[:krupa]]

Sorry everyone, typo on my part. I was blocking bugs to 1033040 and instead blocked it to this bug.

Apologize for the spam.

Comment 12

[Shally Li（leave from Mozilla）]

Hi Jsavory,
   Could you provide the detailed reproduce steps for me to verify this bug?

Thank you!

Comment 13

[Kevin Grandon :kgrandon]

This is trivial to verify, just make sure that the icons match the layout according to the attachment here (Icon_Layout.png).

Comment 14

[Shally Li（leave from Mozilla）]

This issue has been successfully verified on Flame 2.1&2.0.
See attachment: verify_2.1_1.png,verify_2.1_2.png,verify_2.1_3.png and verify_2.0_4.png.
Reproduce rate: 0/3

Flame 2.0 versions:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.032432
FW-Date         Sun Nov 30 03:24:44 EST 2014
Bootloader      L1TC00011880

Flame 2.1 versions:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.034738
FW-Date         Sun Nov 30 03:47:49 EST 2014
Bootloader      L1TC00011880

Comment 15

[Shally Li（leave from Mozilla）]

Attachment: verify_2.0_4.png

Comment 16

[Shally Li（leave from Mozilla）]

Attachment: verify_2.1_1.png

Comment 17

[Shally Li（leave from Mozilla）]

Attachment: verify_2.1_2.png

Comment 18

[Shally Li（leave from Mozilla）]

Attachment: verify_2.1_3.png