Closed Bug 1030465 Opened 6 years ago Closed 5 years ago

[AccessFu] Volume change should update the screen reader volume.

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: yzen, Assigned: yzen)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
There are some inconsistencies with how the screen reader volume is updated. It looks like it depends on context. For example: if the screen reader is currently speaking the volume buttons on the Firefox OS device actually update the screen reader volume. However, when nothing is being spoken, the volume buttons have no effect. 

Note: consider accessibility service in Gaia to potentially address this.
This should be handled by the consumer of the accessfu events (Gaia etc).
Attached file Github pull request.
Fixed up volume related screen reader issues. Added a lot of tests for accessibility.js
Attachment #8465710 - Flags: review?(alive)
Assignee: nobody → yzenevich
Comment on attachment 8465710 [details] [review]
Github pull request.

+1 for accessibility tests. But I don't figure out why the audio.volume.content settings observer is removed and what's the alternative. Could you elaborate more?
Flags: needinfo?(yzenevich)
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #3)
> Comment on attachment 8465710 [details] [review]
> Github pull request.
> 
> +1 for accessibility tests. But I don't figure out why the
> audio.volume.content settings observer is removed and what's the
> alternative. Could you elaborate more?

Hi Alive, so I think we finally settled on what the screen reader volume actually is. It looks like it is indeed played with content volume and we do not want to change it to change the screen reader volume only. Meaning we want the screen reader volume to always be relative to the content volume. 

So what it means is that we have a accessibility.screenreader-volume settings that fits in [0, 1] values. And the number means its relative volume to the channel volume it plays on (e.g. content). 

So for example if content volume is at 10 and screen reader volume at 0.8, then the screen reader volume on content should be 8. Hopefully this explains it a little bit.
Flags: needinfo?(yzenevich)
Comment on attachment 8465710 [details] [review]
Github pull request.

I am not sure how could we change 'accessibility.screenreader-volume' but removing content volume observer make sense.
Attachment #8465710 - Flags: review?(alive) → review+
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #5)
> Comment on attachment 8465710 [details] [review]
> Github pull request.
> 
> I am not sure how could we change 'accessibility.screenreader-volume' but
> removing content volume observer make sense.

The setting is available in accessibility settings in the settings app.
https://github.com/mozilla-b2g/gaia/commit/75d12b5d25b153cfd495ae45ac5dcf836e7efa85
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.