The mozilla::pkix test case pkix_cert_extensions.KnownCriticalCEExtension uses an invalid id-ce-inhibitAnyPolicy extension

RESOLVED FIXED in mozilla33

Status

()

Core
Security: PSM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: briansmith, Assigned: briansmith)

Tracking

(Blocks: 1 bug)

Trunk
mozilla33
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 8446258 [details] [diff] [review]
use-valid-inhibitAnyPolicy-in-test.patch

Ny new certificate perser doesn't allow the extnValue field to be an empty OCTET STRING for any extensions we understand. This test fails because it uses an invalid empty OCTET STRING for the id-pe-inhibitAnyPolicy extension, which is considered understood even though we don't process it completely correctly. This patch changes the test case to use a syntactically-correct id-pe-inhibitAnyPolicy extension.
Attachment #8446258 - Flags: review?(dkeeler)
Comment on attachment 8446258 [details] [diff] [review]
use-valid-inhibitAnyPolicy-in-test.patch

Review of attachment 8446258 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8446258 - Flags: review?(dkeeler) → review+
This should be conflict-free.

Tanks for the review!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8f83a0ab5060
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.