1030481 - Remove the file/blob mImmutable member

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P5)

Description

[(no longer active)]

Ben says that mImmutable is no longer useful.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

For the sicking told me so.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Well.. I'm not sure. I thought the only reason we had that was to enable lazily getting the size. But it sounded like the only code path that I knew of where we would need to lazily get the size now eagerly gets the size.

Code inspection should tell you if mImmutable is ever used for anything useful, no?

Comment 3

[(no longer active)]

<http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsDOMFile.cpp#715> seems to be the only place where this does something useful.  There's also a bunch of places where we assert its value.

Comment 4

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 5

[Andrea Marchesini [:baku]]

Attachment: Bug 1030481 - Remove nsIMutable, r?smaug

nsIMutable is used only by DOM Blob/File. But Blobs are immutable by spec.
FileBlobImpl has a couple of lazy member values, but those are called when
the object is cloned in order to be sent to a different thread/process.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61101e3eebb3
Remove nsIMutable, r=smaug

Comment 7

[Andrea Marchesini [:baku]]

Attachment: Bug 1030481 - Remove nsIMutable, r?smaug

nsIMutable is used only by DOM Blob/File. But Blobs are immutable by spec.
FileBlobImpl has a couple of lazy member values, but those are called when
the object is cloned in order to be sent to a different thread/process.

Comment 8

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 61101e3eebb3 (Bug 1030481) for mochitest failures at test_file.xhtml.
https://hg.mozilla.org/integration/autoland/rev/a58cc727dc9423e6b63c1fcc7d6395856a9f91da

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=61101e3eebb37c91916cd4560a954c7e921d79a7&selectedJob=283835524

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283835524&repo=autoland&lineNumber=23275

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2a2413fa317
Remove nsIMutable, r=smaug

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e2a2413fa317