103050 - last index value is passed to nsISHistoryListener::OnHistoryGotoIndex()

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[David Epstein]

related to bug 92664. Tested against mozilla 0.9.4+ Gecko 20011001.
0. In source code, change index in nsIWebNav.cpp: CNsIWebNav::GoToIndexTest() as
appropriate. Currently, it's set to 0.
1. Compile and Launch testembed:
cd /mozilla/embedding/qa/testembed
nmake -f makefile.win
cd /mozilla/dist/WIN_32D.OBJ/bin
testembed
2. Enter in 2+ urls. Make sure you load a total number of urls which exceeds the
index by at least 2. i.e. if the index = 2, enter 4 urls.
3. From Tests menu, select "Add History Listener".
4. From Interfaces menu, select "nsIWebNav"
5. Navigate through tests, until you perform the GoToIndex() test.

Result: OnHistoryGotoIndex() is called, but index value = 3 (the last index
value, since the index starts at 0)
Expected: The index value passed to the listener method = 2 (the true set index).

Comment 1

[David Epstein]

changed qa contact to depstein, assigned to radha.

Comment 2

[Radha on family leave (not reading bugmail)]

David,  as we discussed last week, i don't believe that this is a bug. if you
agree, please close this out. Thanks,

Comment 3

[David Epstein]

this is a different bug: passes to the history listener the last uri index value
instead of the index valued called through goToIndex().

Comment 4

[Radha on family leave (not reading bugmail)]

Attachment: patch to nsSHistory.cpp

Comment 5

[Chak Nanga]

Comment on attachment 57294 [details] [diff] [review]
patch to nsSHistory.cpp

r=chak

Comment 6

[Alec Flett]

Comment on attachment 57294 [details] [diff] [review]
patch to nsSHistory.cpp

sr=alecf

Comment 7

[Radha on family leave (not reading bugmail)]

fix checked in

Comment 8

[Radha on family leave (not reading bugmail)]

Actually marking fixed.

Comment 9

[David Epstein]

fixed. verified in 11/28 mozilla debug build. correct index value is passed to
callback.