1030537 - [prod] post-geoloc migration data appears incorrect

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Matt Brandt [:mbrandt]]

Originally I thought that one of our automated tests failed because geolocation data wasn't set prior to the release/migration for that test account. 

- looking at my own account, https://mozillians.org/u/mbrandt/ I noticed that Country and City are set, but Region is now missing.

Expected:
Country - United States
City - Durango
Region - Colorado

Actual:
Country - United States
City - Durango

Comment 1

[Matt Brandt [:mbrandt]]

In addition https://mozillians.org//country/United%20States/region/Colorado/ should return more results

Comment 2

[William Reynolds [:williamr]]

I'm seeing this issue for several people in the United States. Perhaps all United States profiles? The region is always missing, and in several cases the city is missing.

Before the migration:
Country - United States
City - San Francisco
Region - CA

Expected:
Country - United States
City - San Francisco
Region - California

Actual:
Country - United States

Comment 3

[Andrei [:sancus]]

Looking into this. We didn't delete any of the old data so we should be able to re-run the migration once I figure out what went wrong. There will be some issues with overwriting data people set afterwards, but we can skip profiles that have geo.country, geo.region and geo.city all set already so it shouldn't be too bad.

Comment 4

[William Reynolds [:williamr]]

Sounds like a good plan. Thanks Sancus!

Comment 5

[Andrei [:sancus]]

So... I'm not entirely sure what happened here. The problem is that the data set I uploaded has some bad rows in it, where it doesn't link to the correct objects for region/city. I rebuilt the data set from scratch, and the rebuilt one does not exhibit any of the same problems. I'm not entirely sure what happened to cause the corrupt data set, though.

Still, this should be an easy fix, I am going to upload the fixed data set and have Webops re-run the migration tomorrow asap. This will overwrite any geolocations people set in the meantime, it's unavoidable, but I think that's relatively minor.

Comment 6

[Andrei [:sancus]]

This is fixed now:

https://mozillians.org//country/United%20States/region/Colorado/
https://mozillians.org/en-US/country/United%20States/city/San%20Francisco/
https://mozillians.org/en-US/country/United%20States/region/New%20York/

etc. Some people's profiles are obviously still not going to be migrated properly, but I think we've successfully migrated all the straightforward ones this time.

Comment 7

[Matt Brandt [:mbrandt]]

QA verified on prod --- thank you sancus, the data looks great and our automated tests are purring along happily