Closed Bug 1030542 Opened 6 years ago Closed 5 years ago

remove logging that includes api keys

Categories

(Core :: DOM: Geolocation, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

A few public bug reports included the google api key from the NetworkLocationProvider.  We should not log the API key.
Assignee: nobody → dougt
Attachment #8446299 - Flags: review?(gkeeley)
Comment on attachment 8446299 [details] [diff] [review]
patch to remove the url from being logged.

Agreed. There is plenty of logging, we don't need this url to debug.
Attachment #8446299 - Flags: review?(gkeeley) → review+
+1 to this.

One other option would be to log the url without variable substitution applied. So directly get it from the preference service and log the literal "https://www.googleapis.com/geolocation/v1/geolocate?key=%GOOGLE_API_KEY%"

That might help on desktop, where more users might have changed the geo.wifi.uri pref.
Keywords: checkin-needed
hanno's right.  We could log this to see if QA or a user changes this value to MLS or some other url.
we should get this one in asap.  so follow up?
Attachment #8446299 - Attachment is patch: true
https://hg.mozilla.org/mozilla-central/rev/94e4e5751af2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.