1030627 - Unable to copy failure line text from the log viewer

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

In TBPL, I often find myself copying failure lines from the brief log viewer, in order to paste a quick summary in a bug.

This isn't possible on:
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=182281&repo=mozilla-inbound

ie: Try and copy the failure lines.

(Ideally please can we solve this without using flash? :-))

Comment 1

[Jonathan French (:jfrench)]

I see the same thing. It looks like you can copy but only if you start outside the box boundary while copying the entire page text.

Since each line inside that right hand failure block appears to function as a button, the change will make each line a 'drag-selectable' button. If everyone is ok with that heuristic.

If we wanted to cue the user visually we could remove the btn class entirely, I believe here
https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/partials/lvLogSteps.html#L8

Or perhaps we could do some variant of the .btn class just for that log block, preserving all its existing css styles, color, etc, but omitting:

-webkit-user-select: none;
-moz-user-select: none;
-ms-user-select: none;
-o-user-select: none;

To make it selectable.

I'm happy to poke around if there's agreement to fix it, whichever option is preferred.

Comment 2

[Jonathan French (:jfrench)]

Jeads has confirmed on IRC this is something we'd like fixed, so assigning myself, whichever of the two solutions above we arrive at.

Comment 3

[Jonathan French (:jfrench)]

It turned out to be a bit more involved (for me), but I've got everything working per Ed's needs. We are wrapping the failure text so it is now readable, they are still buttons, they are selectable, and will copy paste with preserved carriage returns from Firefox. Chrome is all the same - except it's not preserving the carriage returns during copy - the pull-left class on those elements kills them on Chrome for some reason. I will look into that more.

Comment 4

[Jonathan French (:jfrench)]

We've opened a PR to evaluate the current implementation
https://github.com/mozilla/treeherder-ui/pull/93

Comment 5

[Jonathan French (:jfrench)]

Camd has merged the PR and kindly pushed to dev
http://treeherder-dev.allizom.org

Ed, can you check it out and confirm it's working for you ok? If so I'll mark it fixed.

Comment 6

[Ed Morley [:emorley]]

(Setting needinfo flag on me to add this to my queue; if you have a question that needs a response - it will make sure I don't miss it :-))

Comment 7

[Ed Morley [:emorley]]

lgtm, thank you :-)

Comment 8

[Jonathan French (:jfrench)]

Thanks Ed, will do. Marking resolved fixed.