Closed Bug 1030655 Opened 10 years ago Closed 10 years ago

[Flame][Email] - fuzzy clear icon

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: fang, Unassigned)

References

Details

Attachments

(5 files)

Attached image 2014-06-25-03-03-36.png
The clear icon of the input field is fuzzy on the new account page in flame device. Please refer to the attached file.
Blocks: 1016987
Attached file Clear icon.zip
Hi Pavel,

Do you think you can help me on update the correct assets of the clear button? Thanks!!
Flags: needinfo?(pivanov)
Hey Fang,

sure ... but can you provide me the Dark version too.
You can see them here:
https://github.com/mozilla-b2g/gaia/tree/master/shared/elements/gaia_textinput/images

Thanks :)
Flags: needinfo?(pivanov) → needinfo?(fshih)
Attached file Clear_dark_icon.zip
Hey Pavel,

For sure! Attached is the dark version. 
Thanks for the help! : )
Flags: needinfo?(fshih)
Attached file patch for Gaia/master
Attachment #8447672 - Flags: ui-review?(fshih)
Attachment #8447672 - Flags: review?(rnowmrch)
Comment on attachment 8447672 [details] [review]
patch for Gaia/master

Code looks good, as long as Fang is ok with the visuals.

Fang, I'm only concerned here: attachment 8447951 [details] 
An example in the phone would be the search input in Music app.
We used to have a white icon, but if that works for you, works for me ;)
Attachment #8447672 - Flags: review?(rnowmrch) → review+
Flags: needinfo?(fshih)
Comment on attachment 8447672 [details] [review]
patch for Gaia/master

The clear icon for white search input in Email app looking good now!
Attachment #8447672 - Flags: ui-review?(fshih) → ui-review+
Flags: needinfo?(fshih)
(In reply to Arnau March  [:arnau] from comment #6)
> Comment on attachment 8447672 [details] [review]
> patch for Gaia/master
> 
> Code looks good, as long as Fang is ok with the visuals.
> 
> Fang, I'm only concerned here: attachment 8447951 [details] 
> An example in the phone would be the search input in Music app.
> We used to have a white icon, but if that works for you, works for me ;)

For the clear icon in dark search input I'm going to flag Hung to see his opinion, since the Music app mainly on dark theme, if that works for him, works for me! 

Hey Hung, Do you think you can help to see if this works? Thanks!!
Flags: needinfo?(hnguyen)
I'm fine with using the same clear icon in the dark scenario as well. 

Thanks for the heads up.
Flags: needinfo?(hnguyen)
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/36935ed58b475341d2e2e520d0d61543e66d515e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: