Closed Bug 1030672 Opened 6 years ago Closed 5 years ago

[Sora][HOMO][o2 Germany][o2 Bug 56785]Regional] DUT doesn't send MMS to email accounts

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S8 (7Nov)

People

(Reporter: sync-1, Assigned: salva)

References

Details

Attachments

(1 file)

Firefox OS v1.3
 Mozilla build ID:20140422024003
 _______________________________________________________________________________
     A.- Overview Description (technical background, concise explanation of the bug):
     
 It is not possible to send MMS to email accounts    
     ________________________________________________________________________________
     B.- Steps to Reproduce (initial conditions, required resources, step by step instructions to reproduce):
     
 1. In client A, create a new MM
 2. In MM header: To-field is set to any legal address (Client B (DuT))
 3. In MM content: Add an email address
 4. In client A, send MM to Client B (DuT)
 5. In Client B (DuT), accept the message .
 6. Verify the pass criteria below.
 
     ________________________________________________________________________________
     C.- Actual Result (current bad behaviour that is reported as a bug):
     
 Email address is properly identified. DUT offers the following options: add to phonebook, send an email to the address detected. DUT doesn't give the option to send MMS to mail address.
     ________________________________________________________________________________
     D.- Expected Result (correct behaviour wished):
     
 In Client B (DuT), the email address can be selected and a MM may be sent. The e-mail address shall appear as the recipient
     
     ________________________________________________________________________________
     E.- Additional information (possible causes suspected, hints to debug, related bugs):
     
 During a new MMS composition, 
 * If a mail address is typed in the destination, the message can't be send (an "!" is shown in red)
 * If a contact with only mail address is selected, DUT will show a message "contact hasn't any phone number"
     ________________________________________________________________________________
     F.- Tracking information (MSISDN, IMEI, other information useful for bug tracking. Required for UK):
     MSISDN: +34616091495
     IMEI: a) IMEI 864604020002857 #001 (42601)
     Other:
I thought we have another bug for this but can't find it, so I'm adding it to the "send mms by email" feature bug.
Blocks: mms-by-email
Assignee: nobody → salva
Comment on attachment 8511935 [details] [review]
Adding the option to send MMS to emails found in messages' bodies.

Please, I'd like a simple unit test for this :)

+ a nit with the l10n key
Attachment #8511935 - Flags: review?(felash)
Sorry, I wanted to ask for feedback. Testing remains of course.
Comment on attachment 8511935 [details] [review]
Adding the option to send MMS to emails found in messages' bodies.

Unit test and l10n note added.
Attachment #8511935 - Flags: review?(felash)
I just want to confirm with Jenny on the order of the items.

Hey Jenny, in this bug we want to handle clicking on an email found in a message body.

What we have currently (with the current patch) is (in this order):
* send an email
* send a multimedia message
* create a new contact
* add to existing contact

Note that we have this even if this email belongs to an existing contact; we don't check this.

I think we should change how we handle emails, especially we should handle it just like a phone number (except that we want the "send email" action).

But maybe the patch is good enough for now (I think the partners want it in some branches) and we can have a follow-up for master?
Flags: needinfo?(jelee)
Added a comment about the unit test and waiting for Jenny's answer.
Attachment #8511935 - Flags: review?(felash)
(In reply to Julien Wajsberg [:julienw] from comment #7)
> Added a comment about the unit test and waiting for Jenny's answer.

I answered to your questions on GitHub and, IMHO, the changes related with how to handle emails of existing contacts should go in a different bug as they are not related specifically with providing the option of sending MMS to email recipients.
Attachment #8511935 - Flags: review?(felash)
(In reply to Salvador de la Puente González [:salva] from comment #8)
> (In reply to Julien Wajsberg [:julienw] from comment #7)
> > Added a comment about the unit test and waiting for Jenny's answer.
> 
> I answered to your questions on GitHub and, IMHO, the changes related with
> how to handle emails of existing contacts should go in a different bug as
> they are not related specifically with providing the option of sending MMS
> to email recipients.

I'll wait for Jenny's answer :)
Hello Julien,

I agree that we should treat email link as phone number. 
Show the following item when email is not saved to contact:

* send an email
* send a multimedia message
* create a new contact
* add to existing contact

Show the following item when email is saved to contact:

* send an email
* send a multimedia message
* view contact

Thanks!
Flags: needinfo?(jelee)
Comment on attachment 8511935 [details] [review]
Adding the option to send MMS to emails found in messages' bodies.

As discussed on IRC, please change the unit test, then request review again.

Please file a separate bug for Jenny's suggestion too.

Thanks!
Attachment #8511935 - Flags: review?(felash)
Comment on attachment 8511935 [details] [review]
Adding the option to send MMS to emails found in messages' bodies.

Done Julien. I repeated the test but with the flag on. Once we remove the flag removing the old test will suffice. What do you think now?
Attachment #8511935 - Flags: review?(felash)
Comment on attachment 8511935 [details] [review]
Adding the option to send MMS to emails found in messages' bodies.

r=me, thanks !
Attachment #8511935 - Flags: review?(felash) → review+
https://github.com/mozilla-b2g/gaia/commit/3016292312cdcc91d75f6cbf3ed1802be073eae4
Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)
You need to log in before you can comment on or make changes to this bug.