1030710 - Remove the "copy to clipboard" flash links

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

When I use treeherder, I get the "Allow foo bar to use flash?" info bar.
I believe treeherder uses Flash for the "copy to clipboard" functionality, but it breaks my workflow, since once you click the "copy to clipboard" link, keyboard shortcuts stop working. In addition, I really don't like the performance hit (/the principal) of using Flash for any more sites than I can help it.

The links currently copy the following to the clipboard:
https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound&revision=cd59e16a415d

However that same link is available from the timestamp of the push, so is redundant.

Please can we just remove it? :-)

Failing that, here are some non-flash ideas for copying to clipboard:
* Using a pop-up and asking them to ctrl+c: http://stackoverflow.com/a/6055620
* Using a hidden div and auto-selecting text using JS: http://stackoverflow.com/a/17528590

Comment 1

[Ed Morley [:emorley]]

Attachment: visual artefacts

I'm also seeing visual artefacts on the flash buttons from time time to. Guessing another byproduct of OMTC on Nightly, but I guess removing them would solve the problem :-)

Comment 2

[Phil Ringnalda (:philor)]

Now that you prompted me to block them with ABP, I've gone from intolerable fan noise whenever I have three or more treeherder tabs open to no noticeable load from them.

Comment 3

[Cameron Dawson [:camd]]

These are all good arguments for removing that feature.  Low hanging fruit, so I'll do that pronto.

Comment 4

[Cameron Dawson [:camd]]

fixed in commit: https://github.com/mozilla/treeherder-ui/commit/d50095858ed78407f5760ee46f8c380d06306c5d

Comment 5

[Cameron Dawson [:camd]]

Attachment: pull request

Comment 6

[Cameron Dawson [:camd]]

Pushed to stage.  I'll push to prod tomorrow morning.

Comment 7

[Ed Morley [:emorley]]

Thank you :-)

Comment 8

[Jonathan French (:jfrench)]

Based on the commit, it looks like neither of the non-flash ideas posed by Ed in Comment#1 to copy to the clipboard were adopted, so treeherder will require regular document text selection by the end user for their copying (eg. log file summaries, other content, etc), correct?

Comment 9

[Ed Morley [:emorley]]

(In reply to Jonathan French (:jfrench) from comment #8)
> Based on the commit, it looks like neither of the non-flash ideas posed by
> Ed in Comment#1 to copy to the clipboard were adopted, so treeherder will
> require regular document text selection by the end user for their copying
> (eg. log file summaries, other content, etc), correct?

Correct - though this is absolutely fine for now - let's wait until we start using Treeherder more before we potentially over-optimise use-cases that are already fine :-)

Comment 10

[Jonathan French (:jfrench)]

Great, thanks Ed. This informs my work on another bug, thanks for the feedback.

Comment 11

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/678139de147dbe22e8d267b4028148b44078dd01
fix Bug 1030710 - remove flash button